This is an archive of the discontinued LLVM Phabricator instance.

Differential D27189

Bitcode: Add a more comprehensive multi-module test now that we have both llvm-cat and llvm-modextract.
ClosedPublic

Authored by pcc on Nov 28 2016, 8:10 PM.

Details

Reviewers
mehdi_amini
Commits
rG8700d91ddb8d: Bitcode: Add a more comprehensive multi-module test now that we have both llvm…
rL288202: Bitcode: Add a more comprehensive multi-module test now that we have both llvm…
Summary

Depends on D26179

Depends on D26778

Diff Detail

Repository
rL LLVM

Event Timeline

pcc updated this revision to Diff 79507.Nov 28 2016, 8:10 PM
pcc retitled this revision from to Bitcode: Add a more comprehensive multi-module test now that we have both llvm-cat and llvm-modextract..
pcc updated this object.
pcc added a reviewer: mehdi_amini.
pcc added parent revisions: D26179: Bitcode: Introduce BitcodeWriter interface., D26778: Add llvm-modextract tool..
pcc added a subscriber: llvm-commits.
mehdi_amini accepted this revision.Nov 28 2016, 10:58 PM
mehdi_amini edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Nov 28 2016, 10:58 PM
mehdi_amini added a comment.Nov 28 2016, 10:59 PM

(I think this could be merged with D26179 if D26778 goes in first, but I don't mind if you commit this separately either)

Closed by commit rL288202: Bitcode: Add a more comprehensive multi-module test now that we have both llvm… (authored by pcc). · Explain WhyNov 29 2016, 2:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
Bitcode/
16 lines

Diff 79641

llvm/trunk/test/Bitcode/multi-module.ll

; RUN: llvm-cat -o %t %s %S/Inputs/multi-module.ll ; RUN: llvm-cat -o %t %s %S/Inputs/multi-module.ll
; RUN: not llvm-dis -o - %t 2>&1 | FileCheck --check-prefix=ERROR %s ; RUN: not llvm-dis -o - %t 2>&1 | FileCheck --check-prefix=ERROR %s
; ERROR: Expected a single module ; ERROR: Expected a single module
; FIXME: Introduce a tool for extracting modules from bitcode and use it here.
; For now we can at least check that the bitcode contains multiple modules.
; RUN: llvm-bcanalyzer -dump %t | FileCheck --check-prefix=BCA %s ; RUN: llvm-bcanalyzer -dump %t | FileCheck --check-prefix=BCA %s
; RUN: llvm-modextract -n 0 -o - %t | llvm-dis | FileCheck --check-prefix=IR1 %s
; RUN: llvm-modextract -n 1 -o - %t | llvm-dis | FileCheck --check-prefix=IR2 %s
; RUN: llvm-as -o %t1 %s ; RUN: llvm-as -o %t1 %s
; RUN: llvm-as -o %t2 %S/Inputs/multi-module.ll ; RUN: llvm-as -o %t2 %S/Inputs/multi-module.ll
; RUN: llvm-cat -o %t %t1 %t2 ; RUN: llvm-cat -o %t %t1 %t2
; RUN: not llvm-dis -o - %t 2>&1 | FileCheck --check-prefix=ERROR %s ; RUN: not llvm-dis -o - %t 2>&1 | FileCheck --check-prefix=ERROR %s
; RUN: llvm-bcanalyzer -dump %t | FileCheck --check-prefix=BCA %s ; RUN: llvm-bcanalyzer -dump %t | FileCheck --check-prefix=BCA %s
; RUN: llvm-cat -b -o %t %t1 %t2 ; RUN: llvm-cat -b -o %t %t1 %t2
; RUN: not llvm-dis -o - %t 2>&1 | FileCheck --check-prefix=ERROR %s ; RUN: not llvm-dis -o - %t 2>&1 | FileCheck --check-prefix=ERROR %s
; RUN: llvm-bcanalyzer -dump %t | FileCheck --check-prefix=BCA %s ; RUN: llvm-bcanalyzer -dump %t | FileCheck --check-prefix=BCA %s
; RUN: llvm-modextract -n 0 -o - %t | llvm-dis | FileCheck --check-prefix=IR1 %s
; RUN: llvm-modextract -n 1 -o - %t | llvm-dis | FileCheck --check-prefix=IR2 %s
; RUN: llvm-cat -b -o %t3 %t %t ; RUN: llvm-cat -b -o %t3 %t %t
; RUN: not llvm-dis -o - %t3 2>&1 | FileCheck --check-prefix=ERROR %s ; RUN: not llvm-dis -o - %t3 2>&1 | FileCheck --check-prefix=ERROR %s
; RUN: llvm-bcanalyzer -dump %t3 | FileCheck --check-prefix=BCA4 %s ; RUN: llvm-bcanalyzer -dump %t3 | FileCheck --check-prefix=BCA4 %s
; RUN: llvm-modextract -n 0 -o - %t3 | llvm-dis | FileCheck --check-prefix=IR1 %s
; RUN: llvm-modextract -n 1 -o - %t3 | llvm-dis | FileCheck --check-prefix=IR2 %s
; RUN: llvm-modextract -n 2 -o - %t3 | llvm-dis | FileCheck --check-prefix=IR1 %s
; RUN: llvm-modextract -n 3 -o - %t3 | llvm-dis | FileCheck --check-prefix=IR2 %s
; BCA: <IDENTIFICATION_BLOCK ; BCA: <IDENTIFICATION_BLOCK
; BCA: <MODULE_BLOCK ; BCA: <MODULE_BLOCK
; BCA: <IDENTIFICATION_BLOCK ; BCA: <IDENTIFICATION_BLOCK
; BCA: <MODULE_BLOCK ; BCA: <MODULE_BLOCK
; BCA4: <IDENTIFICATION_BLOCK ; BCA4: <IDENTIFICATION_BLOCK
; BCA4: <MODULE_BLOCK ; BCA4: <MODULE_BLOCK
; BCA4: <IDENTIFICATION_BLOCK ; BCA4: <IDENTIFICATION_BLOCK
; BCA4: <MODULE_BLOCK ; BCA4: <MODULE_BLOCK
; BCA4: <IDENTIFICATION_BLOCK ; BCA4: <IDENTIFICATION_BLOCK
; BCA4: <MODULE_BLOCK ; BCA4: <MODULE_BLOCK
; BCA4: <IDENTIFICATION_BLOCK ; BCA4: <IDENTIFICATION_BLOCK
; BCA4: <MODULE_BLOCK ; BCA4: <MODULE_BLOCK
; IR1: define void @f1()
; IR2: define void @f2()
define void @f1() { define void @f1() {
ret void ret void
} }