Page MenuHomePhabricator

Object: Set SF_Indirect in ModuleSymbolTable.
ClosedPublic

Authored by pcc on Nov 23 2016, 4:10 PM.

Details

Summary

This lets us remove the last use of IRObjectFile::getSymbolGV() in llvm-nm.

Depends on D27075

Diff Detail

Repository
rL LLVM

Event Timeline

pcc updated this revision to Diff 79168.Nov 23 2016, 4:10 PM
pcc retitled this revision from to Object: Set SF_Indirect in ModuleSymbolTable..
pcc updated this object.
pcc added a reviewer: mehdi_amini.
pcc added subscribers: llvm-commits, rafael.
mehdi_amini edited edge metadata.Nov 23 2016, 7:54 PM

LGTM (with an inline comment)

llvm/tools/llvm-nm/llvm-nm.cpp
1007 ↗(On Diff #79168)

Fuse the two if

mehdi_amini accepted this revision.Nov 23 2016, 7:54 PM
mehdi_amini edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 7:54 PM
pcc updated this revision to Diff 79852.Nov 30 2016, 6:32 PM
pcc marked an inline comment as done.
pcc edited edge metadata.
  • Fuse two ifs
This revision was automatically updated to reflect the committed changes.