Object: Set SF_Indirect in ModuleSymbolTable.

[pcc]

Summary

This lets us remove the last use of IRObjectFile::getSymbolGV() in llvm-nm.

Depends on D27075

[mehdi_amini]

LGTM (with an inline comment)

llvm/tools/llvm-nm/llvm-nm.cpp

1007 ↗

(On Diff #79168)

Fuse the two if

[pcc]

• Fuse two ifs

llvm/trunk/lib/Object/ModuleSymbolTable.cpp

uint32_t ModuleSymbolTable::getSymbolFlags(Symbol S) const {
   else if (GV->hasHiddenVisibility() && !GV->hasLocalLinkage())
     Res |= BasicSymbolRef::SF_Hidden;
   if (const GlobalVariable *GVar = dyn_cast<GlobalVariable>(GV)) {
     if (GVar->isConstant())
       Res |= BasicSymbolRef::SF_Const;
   }
   if (dyn_cast_or_null<Function>(GV->getBaseObject()))
     Res |= BasicSymbolRef::SF_Executable;
+  if (isa<GlobalAlias>(GV))
+    Res |= BasicSymbolRef::SF_Indirect;
   if (GV->hasPrivateLinkage())
     Res |= BasicSymbolRef::SF_FormatSpecific;
   if (!GV->hasLocalLinkage())
     Res |= BasicSymbolRef::SF_Global;
   if (GV->hasCommonLinkage())
     Res |= BasicSymbolRef::SF_Common;
   if (GV->hasLinkOnceLinkage() || GV->hasWeakLinkage() ||
       GV->hasExternalWeakLinkage())

llvm/trunk/tools/llvm-nm/llvm-nm.cpp

if (SegSect.size() != 0 && MachO) {
     // If this section is not in the object file no symbols are printed.
     if (Nsect == 0)
       return;
   }
   for (BasicSymbolRef Sym : Symbols) {
     uint32_t SymFlags = Sym.getFlags();
     if (!DebugSyms && (SymFlags & SymbolRef::SF_FormatSpecific))
       continue;
-    if (WithoutAliases) {
-      if (IRObjectFile *IR = dyn_cast<IRObjectFile>(&Obj)) {
-        const GlobalValue *GV = IR->getSymbolGV(Sym.getRawDataRefImpl());
-        if (GV && isa<GlobalAlias>(GV))
-          continue;
-      }
-    }
+    if (WithoutAliases && (SymFlags & SymbolRef::SF_Indirect))
     // If a "-s segname sectname" option was specified and this is a Mach-O
     // file and this section appears in this file, Nsect will be non-zero then
     // see if this symbol is a symbol from that section and if not skip it.
     if (Nsect && Nsect != getNsectInMachO(*MachO, Sym))
       continue;
     NMSymbol S;
     S.Size = 0;
     S.Address = 0;