This is an archive of the discontinued LLVM Phabricator instance.

Differential D27139

[tsan] Fix the lit expansion of %deflake not to eat a space
ClosedPublic

Authored by kubamracek on Nov 25 2016, 1:34 PM.

Details

Reviewers
dvyukov
zaks.anna
Commits
rG3a481cf0bdbc: [tsan] Fix the lit expansion of %deflake not to eat a space
rCRT287989: [tsan] Fix the lit expansion of %deflake not to eat a space
rL287989: [tsan] Fix the lit expansion of %deflake not to eat a space
Summary

The lit expansion of %deflake (notice the space after) expands in a way that the space is removed, this fixes that.

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 79321.Nov 25 2016, 1:34 PM
kubamracek retitled this revision from to [tsan] Fix the lit expansion of %deflake not to eat a space.
kubamracek updated this object.
kubamracek added reviewers: dvyukov, zaks.anna.
kubamracek set the repository for this revision to rL LLVM.
kubamracek added a project: Restricted Project.
kubamracek added a subscriber: llvm-commits.
dvyukov accepted this revision.Nov 26 2016, 1:11 AM
dvyukov edited edge metadata.
This revision is now accepted and ready to land.Nov 26 2016, 1:11 AM
Closed by commit rL287989: [tsan] Fix the lit expansion of %deflake not to eat a space (authored by kuba.brecka). · Explain WhyNov 26 2016, 11:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
tsan/
2 lines

Diff 79321

test/tsan/lit.cfg

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Linesdef build_invocation(compile_flags):
return " " + " ".join([config.clang] + compile_flags) + " " return " " + " ".join([config.clang] + compile_flags) + " "
config.substitutions.append( ("%clang_tsan ", build_invocation(clang_tsan_cflags)) ) config.substitutions.append( ("%clang_tsan ", build_invocation(clang_tsan_cflags)) )
config.substitutions.append( ("%clangxx_tsan ", build_invocation(clang_tsan_cxxflags)) ) config.substitutions.append( ("%clangxx_tsan ", build_invocation(clang_tsan_cxxflags)) )
# Define CHECK-%os to check for OS-dependent output. # Define CHECK-%os to check for OS-dependent output.
config.substitutions.append( ('CHECK-%os', ("CHECK-" + config.host_os))) config.substitutions.append( ('CHECK-%os', ("CHECK-" + config.host_os)))
config.substitutions.append( ("%deflake ", os.path.join(os.path.dirname(__file__), "deflake.bash")) ) config.substitutions.append( ("%deflake ", os.path.join(os.path.dirname(__file__), "deflake.bash") + " "))
# Default test suffixes. # Default test suffixes.
config.suffixes = ['.c', '.cc', '.cpp', '.m', '.mm'] config.suffixes = ['.c', '.cc', '.cpp', '.m', '.mm']
# ThreadSanitizer tests are currently supported on FreeBSD, Linux and Darwin. # ThreadSanitizer tests are currently supported on FreeBSD, Linux and Darwin.
if config.host_os not in ['FreeBSD', 'Linux', 'Darwin']: if config.host_os not in ['FreeBSD', 'Linux', 'Darwin']:
config.unsupported = True config.unsupported = True
# Allow tests to use REQUIRES=stable-runtime. For use when you cannot use XFAIL # Allow tests to use REQUIRES=stable-runtime. For use when you cannot use XFAIL
# because the test hangs. # because the test hangs.
if config.target_arch != 'aarch64': if config.target_arch != 'aarch64':
config.available_features.add('stable-runtime') config.available_features.add('stable-runtime')