This is an archive of the discontinued LLVM Phabricator instance.

Do not do raw name replacement when FromDecl is a class forward-declaration.
ClosedPublic

Authored by ioeric on Nov 25 2016, 7:46 AM.

Details

Summary

If the FromDecl is a class forward declaration, the reference is
still considered as referring to the original definition given the nature
of forward-declarations, so we can't do a raw name replacement in this case.

Event Timeline

ioeric updated this revision to Diff 79306.Nov 25 2016, 7:46 AM
ioeric retitled this revision from to Do not do raw name replacement when FromDecl is a class forward-declaration..
ioeric updated this object.
ioeric added a reviewer: bkramer.
ioeric added a subscriber: cfe-commits.
bkramer accepted this revision.Nov 25 2016, 8:08 AM
bkramer edited edge metadata.
bkramer added inline comments.
lib/Tooling/Core/Lookup.cpp
131

the "given the nature" part doesn't add any useful information. Either drop it or explain in more detail what's the problem with forward decls.

This revision is now accepted and ready to land.Nov 25 2016, 8:08 AM
ioeric updated this revision to Diff 79307.Nov 25 2016, 8:11 AM
ioeric marked an inline comment as done.
ioeric edited edge metadata.
  • Address comments.
This revision was automatically updated to reflect the committed changes.