This is an archive of the discontinued LLVM Phabricator instance.

Protect std::array tests under noexceptions
ClosedPublic

Authored by rogfer01 on Nov 24 2016, 4:48 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

rogfer01 updated this revision to Diff 79217.Nov 24 2016, 4:48 AM
rogfer01 retitled this revision from to Protect std::array tests under noexceptions.
rogfer01 updated this object.
rogfer01 added reviewers: mclow.lists, EricWF, rmaprath.
rogfer01 added a subscriber: cfe-commits.
mclow.lists accepted this revision.Nov 28 2016, 11:01 AM
mclow.lists edited edge metadata.

Other than the missing asserts, (which are not your fault, but I would appreciate you fixing) this LGTM.

test/std/containers/sequences/array/at.pass.cpp
43 ↗(On Diff #79217)

we should really have an assert(false); after the call to at - to make sure that it actually throws.

Here and below.

This revision is now accepted and ready to land.Nov 28 2016, 11:01 AM
rogfer01 updated this revision to Diff 79589.Nov 29 2016, 9:13 AM
rogfer01 edited edge metadata.

Add missing assertions in the original test.

This revision was automatically updated to reflect the committed changes.