This is an archive of the discontinued LLVM Phabricator instance.

Paths

[libc++] [test] Unbreak variant::swap test for non-libc++ libraries
ClosedPublic

Authored by CaseyCarter on Nov 22 2016, 5:35 PM.

Reviewers

mclow.lists
EricWF

Summary

LIBCPP_ONLY(foo;) at namespace scope is bad, and it should feel bad.

CaseyCarter retitled this revision from to [libc++] [test] Unbreak variant::swap test for non-libc++ libraries.

CaseyCarter updated this object.

Sorry my bad. I thought LIBCPP_ONLY expanded to nothing for non-libc++.

This revision is now accepted and ready to land.Nov 22 2016, 5:51 PM

Path

Size

test/

std/

utilities/

variant/

variant.variant/

variant.swap/

6 lines

Show First 20 Lines • Show All 571 Lines • ▼ Show 20 Lines	void test_swap_noexcept() {
LIBCPP_STATIC_ASSERT(!has_swap_member<V>());		LIBCPP_STATIC_ASSERT(!has_swap_member<V>());
static_assert(std::is_swappable_v<V>, "");		static_assert(std::is_swappable_v<V>, "");
static_assert(std::is_nothrow_swappable_v<V>, "");		static_assert(std::is_nothrow_swappable_v<V>, "");
V v1, v2;		V v1, v2;
swap(v1, v2);		swap(v1, v2);
}		}
}		}

		#ifdef _LIBCPP_VERSION
// This is why variant should SFINAE member swap. :-)		// This is why variant should SFINAE member swap. :-)
LIBCPP_ONLY(template class std::variant<int, NotSwappable>;)		template class std::variant<int, NotSwappable>;
		#endif

int main() {		int main() {
test_swap_valueless_by_exception();		test_swap_valueless_by_exception();
test_swap_same_alternative();		test_swap_same_alternative();
test_swap_different_alternatives();		test_swap_different_alternatives();
test_swap_sfinae();		test_swap_sfinae();
test_swap_noexcept();		test_swap_noexcept();
}		}