Page MenuHomePhabricator

[libc++] [test] Unbreak variant::swap test for non-libc++ libraries
ClosedPublic

Authored by CaseyCarter on Nov 22 2016, 5:35 PM.

Details

Summary

LIBCPP_ONLY(foo;) at namespace scope is bad, and it should feel bad.

Diff Detail

Event Timeline

CaseyCarter retitled this revision from to [libc++] [test] Unbreak variant::swap test for non-libc++ libraries.
CaseyCarter updated this object.
CaseyCarter added reviewers: EricWF, mclow.lists.
CaseyCarter added a subscriber: cfe-commits.
EricWF accepted this revision.Nov 22 2016, 5:51 PM
EricWF edited edge metadata.

Sorry my bad. I thought LIBCPP_ONLY expanded to nothing for non-libc++.

This revision is now accepted and ready to land.Nov 22 2016, 5:51 PM
CaseyCarter closed this revision.Dec 8 2016, 4:26 PM