This is an archive of the discontinued LLVM Phabricator instance.

Differential D27019

[libcxx] [test] Fix MSVC warning C4245 "conversion from 'X' to 'Y', signed/unsigned mismatch", part 6/12.
ClosedPublic

Authored by STL_MSFT on Nov 22 2016, 4:49 PM.

Details

Reviewers
mclow.lists
EricWF
Summary

[libcxx] [test] Fix MSVC warning C4245 "conversion from 'X' to 'Y', signed/unsigned mismatch", part 6/12.

Add static_cast when initializing unsigned integers with negative numbers (in order to obtain big values).

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 78987.Nov 22 2016, 4:49 PM
STL_MSFT retitled this revision from to [libcxx] [test] Fix MSVC warning C4245 "conversion from 'X' to 'Y', signed/unsigned mismatch", part 6/12..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Herald edited edge metadata. · View Herald TranscriptNov 22 2016, 4:49 PM
EricWF accepted this revision.Nov 22 2016, 10:45 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Nov 22 2016, 10:45 PM
STL_MSFT mentioned this in rL287826: [libcxx] [test] D27019: Fix MSVC warning C4245 "conversion from 'X' to 'Y'….Nov 23 2016, 2:12 PM
STL_MSFT closed this revision.Nov 23 2016, 2:17 PM

Thanks, r287826.

Revision Contents

PathSize
test/
std/
input.output/
iostream.format/
output.streams/
ostream.formatted/
ostream.inserters.arithmetic/
2 lines
localization/
locale.categories/
category.numeric/
locale.nm.put/
facet.num.put.members/
10 lines
10 lines
locale.num.get/
facet.num.get.members/
2 lines
2 lines
2 lines
2 lines

Diff 78987

test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/unsigned_long_long.pass.cpp

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Linesint main()
unsigned long long n = 10; unsigned long long n = 10;
os << n; os << n;
assert(sb.str() == "10"); assert(sb.str() == "10");
} }
{ {
testbuf<char> sb; testbuf<char> sb;
std::ostream os(&sb); std::ostream os(&sb);
hex(os); hex(os);
unsigned long long n = -10; unsigned long long n = static_cast<unsigned long long>(-10);
os << n; os << n;
assert(sb.str() == "fffffffffffffff6"); assert(sb.str() == "fffffffffffffff6");
} }
} }

test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_unsigned_long.pass.cpp

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines const my_facet f(1);
unsigned long v = 1; unsigned long v = 1;
char str[50]; char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == "1"); assert(ex == "1");
} }
{ {
std::ios ios(0); std::ios ios(0);
unsigned long v = -1; unsigned long v = static_cast<unsigned long>(-1);
char str[50]; char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == (sizeof(unsigned long) == 4 ? "4294967295" : "18446744073709551615")); assert(ex == (sizeof(unsigned long) == 4 ? "4294967295" : "18446744073709551615"));
} }
{ {
std::ios ios(0); std::ios ios(0);
unsigned long v = -1000; unsigned long v = static_cast<unsigned long>(-1000);
char str[50]; char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == (sizeof(unsigned long) == 4 ? "4294966296" : "18446744073709550616")); assert(ex == (sizeof(unsigned long) == 4 ? "4294966296" : "18446744073709550616"));
} }
{ {
std::ios ios(0); std::ios ios(0);
unsigned long v = 1000; unsigned long v = 1000;
▲ Show 20 Lines • Show All 221 Lines • ▼ Show 20 Lines const my_facet f(1);
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == "****1_00_0"); assert(ex == "****1_00_0");
assert(ios.width() == 0); assert(ios.width() == 0);
} }
{ {
std::ios ios(0); std::ios ios(0);
ios.imbue(std::locale(std::locale::classic(), new my_numpunct)); ios.imbue(std::locale(std::locale::classic(), new my_numpunct));
unsigned long v = -1000; unsigned long v = static_cast<unsigned long>(-1000);
right(ios); right(ios);
showpos(ios); showpos(ios);
ios.width(10); ios.width(10);
char str[50]; char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == (sizeof(unsigned long) == 4 ? "4_294_966_29_6" assert(ex == (sizeof(unsigned long) == 4 ? "4_294_966_29_6"
: "18_446_744_073_709_550_61_6")); : "18_446_744_073_709_550_61_6"));
assert(ios.width() == 0); assert(ios.width() == 0);
} }
{ {
std::ios ios(0); std::ios ios(0);
ios.imbue(std::locale(std::locale::classic(), new my_numpunct)); ios.imbue(std::locale(std::locale::classic(), new my_numpunct));
unsigned long v = -1000; unsigned long v = static_cast<unsigned long>(-1000);
left(ios); left(ios);
ios.width(10); ios.width(10);
char str[50]; char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == (sizeof(unsigned long) == 4 ? "4_294_966_29_6" assert(ex == (sizeof(unsigned long) == 4 ? "4_294_966_29_6"
: "18_446_744_073_709_550_61_6")); : "18_446_744_073_709_550_61_6"));
assert(ios.width() == 0); assert(ios.width() == 0);
} }
{ {
std::ios ios(0); std::ios ios(0);
ios.imbue(std::locale(std::locale::classic(), new my_numpunct)); ios.imbue(std::locale(std::locale::classic(), new my_numpunct));
unsigned long v = -1000; unsigned long v = static_cast<unsigned long>(-1000);
internal(ios); internal(ios);
ios.width(10); ios.width(10);
char str[50]; char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == (sizeof(unsigned long) == 4 ? "4_294_966_29_6" assert(ex == (sizeof(unsigned long) == 4 ? "4_294_966_29_6"
: "18_446_744_073_709_550_61_6")); : "18_446_744_073_709_550_61_6"));
assert(ios.width() == 0); assert(ios.width() == 0);
} }
} }

test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_unsigned_long_long.pass.cpp

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines const my_facet f(1);
unsigned long long v = 1; unsigned long long v = 1;
char str[50]; char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == "1"); assert(ex == "1");
} }
{ {
std::ios ios(0); std::ios ios(0);
unsigned long long v = -1; unsigned long long v = static_cast<unsigned long long>(-1);
char str[50]; char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == (sizeof(unsigned long long) == 4 ? "4294967295" : "18446744073709551615")); assert(ex == (sizeof(unsigned long long) == 4 ? "4294967295" : "18446744073709551615"));
} }
{ {
std::ios ios(0); std::ios ios(0);
unsigned long long v = -1000; unsigned long long v = static_cast<unsigned long long>(-1000);
char str[50]; char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == "18446744073709550616"); assert(ex == "18446744073709550616");
} }
{ {
std::ios ios(0); std::ios ios(0);
unsigned long long v = 1000; unsigned long long v = 1000;
▲ Show 20 Lines • Show All 221 Lines • ▼ Show 20 Lines const my_facet f(1);
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == "****1_00_0"); assert(ex == "****1_00_0");
assert(ios.width() == 0); assert(ios.width() == 0);
} }
{ {
std::ios ios(0); std::ios ios(0);
ios.imbue(std::locale(std::locale::classic(), new my_numpunct)); ios.imbue(std::locale(std::locale::classic(), new my_numpunct));
unsigned long long v = -1000; unsigned long long v = static_cast<unsigned long long>(-1000);
right(ios); right(ios);
showpos(ios); showpos(ios);
ios.width(10); ios.width(10);
char str[50]; char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == "18_446_744_073_709_550_61_6"); assert(ex == "18_446_744_073_709_550_61_6");
assert(ios.width() == 0); assert(ios.width() == 0);
} }
{ {
std::ios ios(0); std::ios ios(0);
ios.imbue(std::locale(std::locale::classic(), new my_numpunct)); ios.imbue(std::locale(std::locale::classic(), new my_numpunct));
unsigned long long v = -1000; unsigned long long v = static_cast<unsigned long long>(-1000);
left(ios); left(ios);
ios.width(10); ios.width(10);
char str[50]; char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == "18_446_744_073_709_550_61_6"); assert(ex == "18_446_744_073_709_550_61_6");
assert(ios.width() == 0); assert(ios.width() == 0);
} }
{ {
std::ios ios(0); std::ios ios(0);
ios.imbue(std::locale(std::locale::classic(), new my_numpunct)); ios.imbue(std::locale(std::locale::classic(), new my_numpunct));
unsigned long long v = -1000; unsigned long long v = static_cast<unsigned long long>(-1000);
internal(ios); internal(ios);
ios.width(10); ios.width(10);
char str[50]; char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v); output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base()); std::string ex(str, iter.base());
assert(ex == "18_446_744_073_709_550_61_6"); assert(ex == "18_446_744_073_709_550_61_6");
assert(ios.width() == 0); assert(ios.width() == 0);
} }
} }

test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_unsigned_int.pass.cpp

Show All 39 Linesprotected:
virtual char_type do_thousands_sep() const {return '_';} virtual char_type do_thousands_sep() const {return '_';}
virtual std::string do_grouping() const {return std::string("\1\2\3");} virtual std::string do_grouping() const {return std::string("\1\2\3");}
}; };
int main() int main()
{ {
const my_facet f(1); const my_facet f(1);
std::ios ios(0); std::ios ios(0);
unsigned int v = -1; unsigned int v = static_cast<unsigned int>(-1);
{ {
const char str[] = "0"; const char str[] = "0";
std::ios_base::iostate err = ios.goodbit; std::ios_base::iostate err = ios.goodbit;
input_iterator<const char*> iter = input_iterator<const char*> iter =
f.get(input_iterator<const char*>(str), f.get(input_iterator<const char*>(str),
input_iterator<const char*>(str+sizeof(str)), input_iterator<const char*>(str+sizeof(str)),
ios, err, v); ios, err, v);
assert(iter.base() == str+sizeof(str)-1); assert(iter.base() == str+sizeof(str)-1);
Show All 27 Lines

test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_unsigned_long.pass.cpp

Show All 39 Linesprotected:
virtual char_type do_thousands_sep() const {return '_';} virtual char_type do_thousands_sep() const {return '_';}
virtual std::string do_grouping() const {return std::string("\1\2\3");} virtual std::string do_grouping() const {return std::string("\1\2\3");}
}; };
int main() int main()
{ {
const my_facet f(1); const my_facet f(1);
std::ios ios(0); std::ios ios(0);
unsigned long v = -1; unsigned long v = static_cast<unsigned long>(-1);
{ {
const char str[] = "0"; const char str[] = "0";
std::ios_base::iostate err = ios.goodbit; std::ios_base::iostate err = ios.goodbit;
input_iterator<const char*> iter = input_iterator<const char*> iter =
f.get(input_iterator<const char*>(str), f.get(input_iterator<const char*>(str),
input_iterator<const char*>(str+sizeof(str)), input_iterator<const char*>(str+sizeof(str)),
ios, err, v); ios, err, v);
assert(iter.base() == str+sizeof(str)-1); assert(iter.base() == str+sizeof(str)-1);
Show All 27 Lines

test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_unsigned_long_long.pass.cpp

Show All 39 Linesprotected:
virtual char_type do_thousands_sep() const {return '_';} virtual char_type do_thousands_sep() const {return '_';}
virtual std::string do_grouping() const {return std::string("\1\2\3");} virtual std::string do_grouping() const {return std::string("\1\2\3");}
}; };
int main() int main()
{ {
const my_facet f(1); const my_facet f(1);
std::ios ios(0); std::ios ios(0);
unsigned long long v = -1; unsigned long long v = static_cast<unsigned long long>(-1);
{ {
const char str[] = "0"; const char str[] = "0";
std::ios_base::iostate err = ios.goodbit; std::ios_base::iostate err = ios.goodbit;
input_iterator<const char*> iter = input_iterator<const char*> iter =
f.get(input_iterator<const char*>(str), f.get(input_iterator<const char*>(str),
input_iterator<const char*>(str+sizeof(str)), input_iterator<const char*>(str+sizeof(str)),
ios, err, v); ios, err, v);
assert(iter.base() == str+sizeof(str)-1); assert(iter.base() == str+sizeof(str)-1);
Show All 27 Lines

test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_unsigned_short.pass.cpp

Show All 39 Linesprotected:
virtual char_type do_thousands_sep() const {return '_';} virtual char_type do_thousands_sep() const {return '_';}
virtual std::string do_grouping() const {return std::string("\1\2\3");} virtual std::string do_grouping() const {return std::string("\1\2\3");}
}; };
int main() int main()
{ {
const my_facet f(1); const my_facet f(1);
std::ios ios(0); std::ios ios(0);
unsigned short v = -1; unsigned short v = static_cast<unsigned short>(-1);
{ {
const char str[] = "0"; const char str[] = "0";
std::ios_base::iostate err = ios.goodbit; std::ios_base::iostate err = ios.goodbit;
input_iterator<const char*> iter = input_iterator<const char*> iter =
f.get(input_iterator<const char*>(str), f.get(input_iterator<const char*>(str),
input_iterator<const char*>(str+sizeof(str)), input_iterator<const char*>(str+sizeof(str)),
ios, err, v); ios, err, v);
assert(iter.base() == str+sizeof(str)-1); assert(iter.base() == str+sizeof(str)-1);
Show All 27 Lines