This is an archive of the discontinued LLVM Phabricator instance.

[LLVM] [ADT] Fix some Clang-tidy modernize-use-default and Include What You Use warnings; other minor fixes
ClosedPublic

Authored by Eugene.Zelenko on Nov 22 2016, 1:58 PM.

Details

Summary

I checked this patch on my own build on RHEL 6. Regressions were OK.

I think review in Phabricator will be better because ADT is fundamental part of LLVM and changes there cause long rebuilds.

Diff Detail

Repository
rL LLVM

Event Timeline

Eugene.Zelenko retitled this revision from to [LLVM] [ADT] Fix some Clang-tidy modernize-use-default and Include What You Use warnings; other minor fixes.
Eugene.Zelenko updated this object.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: llvm-commits.
mehdi_amini accepted this revision.Nov 22 2016, 3:29 PM
mehdi_amini edited edge metadata.

I didn't quite get why you put it up for review? Why does the "ADT takes a long time to build" matter?

include/llvm/ADT/StringMap.h
20

There are no assert in this file, why is this needed?

This revision is now accepted and ready to land.Nov 22 2016, 3:29 PM

I put on review, some build bots could be slow.

include/llvm/ADT/StringMap.h
20

Asserts are used twice. May be file was not expanded when you look onto it?

mehdi_amini added inline comments.Nov 22 2016, 3:34 PM
include/llvm/ADT/StringMap.h
20

Likely!

This revision was automatically updated to reflect the committed changes.