This is an archive of the discontinued LLVM Phabricator instance.

[X86] Simplify lowerVectorShuffleAsBitMask to handle only integer VT's
ClosedPublic

Authored by zvi on Nov 22 2016, 11:51 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

zvi updated this revision to Diff 78909.Nov 22 2016, 11:51 AM
zvi retitled this revision from to [X86] Simplify lowerVectorShuffleAsBitMask to handle only integer VT's.
zvi updated this object.
zvi added reviewers: andreadb, RKSimon, craig.topper, delena.
zvi set the repository for this revision to rL LLVM.
zvi added a subscriber: llvm-commits.
andreadb accepted this revision.Nov 22 2016, 12:17 PM
andreadb edited edge metadata.

Sounds reasonable to me.
In practice, lowerVectorShuffleAsBitMask is only called when the shuffle valuetype is integer. In all other cases, the lowering logic forces a bitcast on the shuffle operands.

This revision is now accepted and ready to land.Nov 22 2016, 12:17 PM
This revision was automatically updated to reflect the committed changes.