This is an archive of the discontinued LLVM Phabricator instance.

Remove unused check::RegionChanges::wantsRegionChangeUpdate callback
ClosedPublic

Authored by k-wisniewski on Nov 16 2016, 11:51 AM.

Details

Summary

Hi!

I've noticed that check::RegionChanges::wantsRegionChangeUpdate is no longer used - as far as the discussion went it has been unused at least since checkPointerEscape has been added. This patch removes unused code as a part of cleanup/improvement in check::RegionChanges that I have undertaken. Let's discuss the necessity of such action here and decide upon it asap, because I need to know what to do with my another patch that adds LocationContext (or CheckerContext) to check::RegionChanges::checkRegionChanges.

Diff Detail

Event Timeline

k-wisniewski retitled this revision from to Remove unused check::RegionChanges::wantsRegionChangeUpdate callback.
k-wisniewski updated this object.
k-wisniewski added a subscriber: cfe-commits.
zaks.anna accepted this revision.Nov 16 2016, 12:18 PM
zaks.anna edited edge metadata.

Looks great!

This revision is now accepted and ready to land.Nov 16 2016, 12:18 PM
zaks.anna added inline comments.Nov 16 2016, 12:21 PM
lib/StaticAnalyzer/Core/CheckerManager.cpp
535

Looks like the other patch leaked in here: you have LCtx.

k-wisniewski edited edge metadata.

Removed a line that leaked from another diff - thanks Anna!

This revision was automatically updated to reflect the committed changes.