MIPS GOT handling is very different from other targets so it is better to keep the code in the separatre section class MipsGotSection. This patch introduces the new section and moves all MIPS specific code from GotSection to the new class. I did not rename fields and methods in the MipsGotSection class to reduce the diff and plan to do that by the separate commit.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM with a nit.
ELF/Relocations.cpp | ||
---|---|---|
99 | Got can be set in the function, no need to make it an argument. |
ELF/Relocations.cpp | ||
---|---|---|
99 |
I'm not sure that it is possible. GotSection used by ARM and MipsGotSection used by MIPS both have methods like addDynTlsEntry, getGlobalDynOffset etc but these methods are not virtual and are not defined in any base class. That is why I use GOT template argument. |
Got can be set in the function, no need to make it an argument.