This is an archive of the discontinued LLVM Phabricator instance.

[LV] Stop saying "use -Rpass-analysis=loop-vectorize"
ClosedPublic

Authored by anemet on Nov 11 2016, 2:19 PM.

Details

Summary

This is PR28376.

Unfortunately given the current structure of optimization diagnostics we
lack the capability to tell whether the user has
passed -Rpass-analysis=loop-vectorize since this is local to the
front-end (BackendConsumer::OptimizationRemarkHandler).

So rather than printing this even if the user has already
passed -Rpass-analysis, this patch just punts and stops recommending
this option. I don't think that getting this right is worth the
complexity.

Event Timeline

anemet updated this revision to Diff 77668.Nov 11 2016, 2:19 PM
anemet retitled this revision from to [LV] Stop saying "use -Rpass-analysis=loop-vectorize".
anemet updated this object.
anemet added a reviewer: hfinkel.
anemet added a subscriber: llvm-commits.
mzolotukhin accepted this revision.Nov 11 2016, 2:27 PM
mzolotukhin added a reviewer: mzolotukhin.

Makes sense to me (you might want to wait for others' opinion though).

Michael

This revision is now accepted and ready to land.Nov 11 2016, 2:27 PM
hfinkel edited edge metadata.Nov 11 2016, 2:34 PM

Makes sense to me (you might want to wait for others' opinion though).

Michael

Yes, please. We should not mention Clang flags in backend messages.

This revision was automatically updated to reflect the committed changes.