This is an archive of the discontinued LLVM Phabricator instance.

Differential D26541

[cmake] Fix missing linked libraries for llvm-strings
AbandonedPublic

Authored by mgorny on Nov 11 2016, 12:59 AM.

Details

Reviewers
compnerd
beanz
mehdi_amini
Summary

Add missing linkage to Core & Support libraries for llvm-strings, in
order to fix the undefined references (when using split shared
libraries).

Diff Detail

Event Timeline

mgorny updated this revision to Diff 77599.Nov 11 2016, 12:59 AM
mgorny retitled this revision from to [cmake] Fix missing linked libraries for llvm-strings.
mgorny updated this object.
mgorny added reviewers: compnerd, mehdi_amini, beanz.
mgorny added a subscriber: llvm-commits.
mgorny abandoned this revision.Nov 11 2016, 9:05 AM

Fixed independently in rL286594

Revision Contents

PathSize
tools/
llvm-strings/
2 lines

Diff 77599

tools/llvm-strings/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Core
Object Object
Support
) )
add_llvm_tool(llvm-strings add_llvm_tool(llvm-strings
llvm-strings.cpp llvm-strings.cpp
) )