Page MenuHomePhabricator

Disable windows-only minidump plugin
ClosedPublic

Authored by labath on Nov 8 2016, 5:17 AM.

Details

Summary

This commit disables the windows-only minidump plugin and enables the new
cross-platform plugin for windows minidump files. Test decorators are adjusted to
reflect that: windows minidump tests can now run on all platforms. The exception
is the tests that create minidump files, as that functionality is not available
yet.

I've checked that this works on windows and linux. If it goes well on the bots,
I'll delete the old plugin in a follow-up.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 77175.Nov 8 2016, 5:17 AM
labath retitled this revision from to Disable windows-only minidump plugin.
labath updated this object.
labath added reviewers: amccarth, zturner.
labath added subscribers: lldb-commits, dvlahovski.
amccarth edited edge metadata.Nov 8 2016, 9:24 AM

I started testing the new plugin on Windows yesterday, and it doesn't work (all the tests fail). I'm planning to debug today, and, once I get it working, I'd be happy to switch it over.

labath added a comment.Nov 8 2016, 9:44 AM

I started testing the new plugin on Windows yesterday, and it doesn't work (all the tests fail). I'm planning to debug today, and, once I get it working, I'd be happy to switch it over.

Interesting. It seemed to work fine for me. How did you test that?

I started testing the new plugin on Windows yesterday, and it doesn't work (all the tests fail). I'm planning to debug today, and, once I get it working, I'd be happy to switch it over.

Interesting. It seemed to work fine for me. How did you test that?

I made changes very similar to this patch and ran check-lldb. The tests for the new minidump plugin passed, but the original Windows ones all failed, apparently because it cannot find any threads in the dumps. I'll have more time to look at it this afternoon.

amccarth accepted this revision.Nov 8 2016, 11:23 AM
amccarth edited edge metadata.

Problem was at my end. This patch works fine for me now.

I'm planning to do some more minidump work, so I'd be happy to take over with eliminating the old Windows-specific implementation.

This revision is now accepted and ready to land.Nov 8 2016, 11:23 AM
labath added a comment.Nov 9 2016, 2:19 AM

Yeah, feel free to take over. I was not planning to do any more work here - just wanted to wrap things up. I am going to commit this then, and leave the rest to you.

This revision was automatically updated to reflect the committed changes.