This is an archive of the discontinued LLVM Phabricator instance.

Differential D26377

[libc++] Remove unnecessary MSVCRT exclusions
ClosedPublic

Authored by smeenai on Nov 7 2016, 4:32 PM.

Details

Reviewers
mclow.lists
compnerd
EricWF
Commits
rG76728d88ec5e: [libc++] Remove unnecessary MSVCRT exclusions
rCXX286202: [libc++] Remove unnecessary MSVCRT exclusions
rL286202: [libc++] Remove unnecessary MSVCRT exclusions
Summary

Visual Studio 2013 and up have these functions, and we don't need to
support older versions.

There are some remaining _LIBCPP_MSVCRT exclusions which are present on
Visual Studio 2015 but not 2013. Those will be addressed in a follow-up.

Diff Detail

Repository
rL LLVM

Event Timeline

smeenai updated this revision to Diff 77117.Nov 7 2016, 4:32 PM
smeenai retitled this revision from to [libc++] Remove unnecessary MSVCRT exclusions.
smeenai updated this object.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
smeenai updated this revision to Diff 77119.Nov 7 2016, 4:52 PM
smeenai updated this object.

Fixing some more exclusions

EricWF accepted this revision.Nov 7 2016, 6:14 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 6:14 PM
Closed by commit rL286202: [libc++] Remove unnecessary MSVCRT exclusions (authored by smeenai). · Explain WhyNov 7 2016, 7:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libcxx/
trunk/
include/
6 lines
2 lines
6 lines

Diff 77136

libcxx/trunk/include/cmath

Show First 20 Lines • Show All 380 Lines • ▼ Show 20 Lines
using ::sqrt; using ::sqrt;
using ::sqrtf; using ::sqrtf;
using ::tan; using ::tan;
using ::tanf; using ::tanf;
using ::tanh; using ::tanh;
using ::tanhf; using ::tanhf;
#ifndef _LIBCPP_MSVCRT
using ::acosh; using ::acosh;
using ::acoshf; using ::acoshf;
using ::asinh; using ::asinh;
using ::asinhf; using ::asinhf;
using ::atanh; using ::atanh;
using ::atanhf; using ::atanhf;
using ::cbrt; using ::cbrt;
using ::cbrtf; using ::cbrtf;
#endif
using ::copysign; using ::copysign;
using ::copysignf; using ::copysignf;
#ifndef _LIBCPP_MSVCRT #ifndef _LIBCPP_MSVCRT
using ::erf; using ::erf;
using ::erff; using ::erff;
using ::erfc; using ::erfc;
Show All 27 Lines
using ::logb; using ::logb;
using ::logbf; using ::logbf;
using ::lrint; using ::lrint;
using ::lrintf; using ::lrintf;
using ::lround; using ::lround;
using ::lroundf; using ::lroundf;
#endif // _LIBCPP_MSVCRT #endif // _LIBCPP_MSVCRT
#ifndef _LIBCPP_MSVCRT
using ::nan; using ::nan;
using ::nanf; using ::nanf;
#endif // _LIBCPP_MSVCRT
#ifndef _LIBCPP_MSVCRT #ifndef _LIBCPP_MSVCRT
using ::nearbyint; using ::nearbyint;
using ::nearbyintf; using ::nearbyintf;
using ::nextafter; using ::nextafter;
using ::nextafterf; using ::nextafterf;
using ::nexttoward; using ::nexttoward;
using ::nexttowardf; using ::nexttowardf;
Show All 32 Lines
using ::log10l; using ::log10l;
using ::modfl; using ::modfl;
using ::powl; using ::powl;
using ::sinl; using ::sinl;
using ::sinhl; using ::sinhl;
using ::sqrtl; using ::sqrtl;
using ::tanl; using ::tanl;
#ifndef _LIBCPP_MSVCRT
using ::tanhl; using ::tanhl;
using ::acoshl; using ::acoshl;
using ::asinhl; using ::asinhl;
using ::atanhl; using ::atanhl;
using ::cbrtl; using ::cbrtl;
#endif // !_LIBCPP_MSVCRT
using ::copysignl; using ::copysignl;
#ifndef _LIBCPP_MSVCRT #ifndef _LIBCPP_MSVCRT
using ::erfl; using ::erfl;
using ::erfcl; using ::erfcl;
using ::exp2l; using ::exp2l;
using ::expm1l; using ::expm1l;
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines

libcxx/trunk/include/cstdio

Show First 20 Lines • Show All 115 Lines • ▼ Show 20 Lines
using ::fflush; using ::fflush;
using ::setbuf; using ::setbuf;
using ::setvbuf; using ::setvbuf;
using ::fprintf; using ::fprintf;
using ::fscanf; using ::fscanf;
using ::snprintf; using ::snprintf;
using ::sprintf; using ::sprintf;
using ::sscanf; using ::sscanf;
#ifndef _LIBCPP_MSVCRT
using ::vfprintf; using ::vfprintf;
using ::vfscanf; using ::vfscanf;
using ::vsscanf; using ::vsscanf;
#endif // _LIBCPP_MSVCRT
using ::vsnprintf; using ::vsnprintf;
using ::vsprintf; using ::vsprintf;
using ::fgetc; using ::fgetc;
using ::fgets; using ::fgets;
using ::fputc; using ::fputc;
using ::fputs; using ::fputs;
using ::getc; using ::getc;
using ::putc; using ::putc;
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines

libcxx/trunk/include/cwchar

Show First 20 Lines • Show All 117 Lines • ▼ Show 20 Lines
using ::tm; using ::tm;
using ::wint_t; using ::wint_t;
using ::FILE; using ::FILE;
using ::fwprintf; using ::fwprintf;
using ::fwscanf; using ::fwscanf;
using ::swprintf; using ::swprintf;
using ::vfwprintf; using ::vfwprintf;
using ::vswprintf; using ::vswprintf;
#ifndef _LIBCPP_MSVCRT
using ::swscanf; using ::swscanf;
using ::vfwscanf; using ::vfwscanf;
using ::vswscanf; using ::vswscanf;
#endif // _LIBCPP_MSVCRT
using ::fgetwc; using ::fgetwc;
using ::fgetws; using ::fgetws;
using ::fputwc; using ::fputwc;
using ::fputws; using ::fputws;
using ::fwide; using ::fwide;
using ::getwc; using ::getwc;
using ::putwc; using ::putwc;
using ::ungetwc; using ::ungetwc;
using ::wcstod; using ::wcstod;
#ifndef _LIBCPP_MSVCRT
using ::wcstof; using ::wcstof;
using ::wcstold; using ::wcstold;
#endif // _LIBCPP_MSVCRT
using ::wcstol; using ::wcstol;
#ifndef _LIBCPP_HAS_NO_LONG_LONG #ifndef _LIBCPP_HAS_NO_LONG_LONG
using ::wcstoll; using ::wcstoll;
#endif // _LIBCPP_HAS_NO_LONG_LONG #endif // _LIBCPP_HAS_NO_LONG_LONG
using ::wcstoul; using ::wcstoul;
#ifndef _LIBCPP_HAS_NO_LONG_LONG #ifndef _LIBCPP_HAS_NO_LONG_LONG
using ::wcstoull; using ::wcstoull;
#endif // _LIBCPP_HAS_NO_LONG_LONG #endif // _LIBCPP_HAS_NO_LONG_LONG
Show All 25 Lines
using ::mbrlen; using ::mbrlen;
using ::mbrtowc; using ::mbrtowc;
using ::wcrtomb; using ::wcrtomb;
using ::mbsrtowcs; using ::mbsrtowcs;
using ::wcsrtombs; using ::wcsrtombs;
#ifndef _LIBCPP_HAS_NO_STDIN #ifndef _LIBCPP_HAS_NO_STDIN
using ::getwchar; using ::getwchar;
#ifndef _LIBCPP_MSVCRT
using ::vwscanf; using ::vwscanf;
#endif // _LIBCPP_MSVCRT
using ::wscanf; using ::wscanf;
#endif #endif
#ifndef _LIBCPP_HAS_NO_STDOUT #ifndef _LIBCPP_HAS_NO_STDOUT
using ::putwchar; using ::putwchar;
using ::vwprintf; using ::vwprintf;
using ::wprintf; using ::wprintf;
#endif #endif
_LIBCPP_END_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
#endif // _LIBCPP_CWCHAR #endif // _LIBCPP_CWCHAR