This is an archive of the discontinued LLVM Phabricator instance.

[ClangTidy] Move incomplete type test into separate test file
ClosedPublic

Authored by flx on Nov 7 2016, 1:19 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

flx updated this revision to Diff 77088.Nov 7 2016, 1:19 PM
flx retitled this revision from to [ClangTidy] Move incomplete type test into separate test file.
flx updated this object.
flx added reviewers: alexfh, aaron.ballman, sbenza.
flx set the repository for this revision to rL LLVM.
flx added a subscriber: cfe-commits.
aaron.ballman added inline comments.Nov 7 2016, 1:43 PM
test/clang-tidy/performance-unnecessary-value-param.cpp
257

Why are these tests being removed?

flx updated this revision to Diff 77094.Nov 7 2016, 1:46 PM
flx removed rL LLVM as the repository for this revision.
flx marked an inline comment as done.
flx added inline comments.
test/clang-tidy/performance-unnecessary-value-param.cpp
257

They should not be removed. Restored them.

aaron.ballman accepted this revision.Nov 7 2016, 1:49 PM
aaron.ballman edited edge metadata.

LGTM!

test/clang-tidy/performance-unnecessary-value-param.cpp
257

Yay code review process! :-)

This revision is now accepted and ready to land.Nov 7 2016, 1:49 PM
flx marked an inline comment as done.Nov 7 2016, 1:52 PM
flx added inline comments.
test/clang-tidy/performance-unnecessary-value-param.cpp
257

Absolutely. Thanks for the quick review!

This revision was automatically updated to reflect the committed changes.