This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Check runtimes subdir when looking for libcxx and libuwind
ClosedPublic

Authored by phosek on Nov 7 2016, 12:09 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek updated this revision to Diff 77075.Nov 7 2016, 12:09 PM
phosek retitled this revision from to [CMake] Check runtimes subdir when looking for libcxx and libuwind.
phosek updated this object.
phosek added reviewers: beanz, EricWF.
phosek set the repository for this revision to rL LLVM.
phosek added a subscriber: llvm-commits.
beanz accepted this revision.Nov 7 2016, 4:26 PM
beanz edited edge metadata.

LGTM!

This revision is now accepted and ready to land.Nov 7 2016, 4:26 PM
This revision was automatically updated to reflect the committed changes.
phosek updated this revision to Diff 77308.Nov 8 2016, 8:43 PM
phosek edited edge metadata.

The original version caused a build breakage because LIBCXXABI_LIBCXX_SRC_DIR was used both as a string and a list in different contexts. This is a reland of the same change which addresses that issue, please take a look.

phosek reopened this revision.Nov 8 2016, 8:43 PM
This revision is now accepted and ready to land.Nov 8 2016, 8:43 PM
This revision was automatically updated to reflect the committed changes.