Remove KQueue.cpp

[labath]

Summary

This class is unused (and apple specific, so it does not really belong into
generic code). Can we remove it?

[clayborg]

As long as no one is using it in the Xcode project or in liblldb we can remove it.

lldb.xcodeproj/project.pbxproj

/* Begin PBXBuildFile section */
     26C72C961243229A0068DC16 /* SBStream.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26C72C951243229A0068DC16 /* SBStream.cpp */; };
     26C7C4831BFFEA7E009BD01F /* WindowsMiniDump.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26C7C4811BFFEA7E009BD01F /* WindowsMiniDump.cpp */; };
     26C7C4841BFFEA7E009BD01F /* WindowsMiniDump.h in Headers */ = {isa = PBXBuildFile; fileRef = 26C7C4821BFFEA7E009BD01F /* WindowsMiniDump.h */; };
     26CA97A1172B1FD5005DC71B /* RegisterContextThreadMemory.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26CA979F172B1FD5005DC71B /* RegisterContextThreadMemory.cpp */; };
     26CEB5EF18761CB2008F575A /* libedit.dylib in Frameworks */ = {isa = PBXBuildFile; fileRef = 26F5C32A10F3DFDD009D5894 /* libedit.dylib */; };
     26CEB5F218762056008F575A /* CommandObjectGUI.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26CEB5F018762056008F575A /* CommandObjectGUI.cpp */; };
     26CFDCA3186163A4000E63E5 /* Editline.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26CFDCA2186163A4000E63E5 /* Editline.cpp */; };
     26CFDCA818616473000E63E5 /* libedit.dylib in Frameworks */ = {isa = PBXBuildFile; fileRef = 26F5C32A10F3DFDD009D5894 /* libedit.dylib */; };
-    26D1803E16CEBFD300EDFB5B /* KQueue.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26D1803C16CEBFD300EDFB5B /* KQueue.cpp */; };
     26D1804216CEDF0700EDFB5B /* TimeSpecTimeout.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26D1804016CEDF0700EDFB5B /* TimeSpecTimeout.cpp */; };
     26D265BC136B4269002EEE45 /* lldb-public.h in Headers */ = {isa = PBXBuildFile; fileRef = 26651A14133BEC76005B64B7 /* lldb-public.h */; settings = {ATTRIBUTES = (Public, ); }; };
     26D52C1F1A980FE300E5D2FB /* MICmdCmdSymbol.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26D52C1D1A980FE300E5D2FB /* MICmdCmdSymbol.cpp */; };
     26D55235159A7DB100708D8D /* libxml2.dylib in Frameworks */ = {isa = PBXBuildFile; fileRef = 26D55234159A7DB100708D8D /* libxml2.dylib */; };
     26D5E15F135BAEA2006EA0A7 /* OptionGroupArchitecture.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26D5E15E135BAEA2006EA0A7 /* OptionGroupArchitecture.cpp */; };
     26D5E163135BB054006EA0A7 /* OptionGroupPlatform.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26D5E162135BB054006EA0A7 /* OptionGroupPlatform.cpp */; };
     26D7E45D13D5E30A007FD12B /* SocketAddress.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26D7E45C13D5E30A007FD12B /* SocketAddress.cpp */; };
     26DAED6315D327C200E15819 /* OptionValuePathMappings.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26DAED6215D327C200E15819 /* OptionValuePathMappings.cpp */; };

     26CFDCA01861638D000E63E5 /* Editline.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Editline.h; path = include/lldb/Host/Editline.h; sourceTree = "<group>"; };
     26CFDCA2186163A4000E63E5 /* Editline.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Editline.cpp; sourceTree = "<group>"; };
     26D0DD5010FE554D00271C65 /* BreakpointResolverAddress.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = BreakpointResolverAddress.h; path = include/lldb/Breakpoint/BreakpointResolverAddress.h; sourceTree = "<group>"; };
     26D0DD5110FE554D00271C65 /* BreakpointResolverFileLine.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = BreakpointResolverFileLine.h; path = include/lldb/Breakpoint/BreakpointResolverFileLine.h; sourceTree = "<group>"; };
     26D0DD5210FE554D00271C65 /* BreakpointResolverName.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = BreakpointResolverName.h; path = include/lldb/Breakpoint/BreakpointResolverName.h; sourceTree = "<group>"; };
     26D0DD5310FE555900271C65 /* BreakpointResolverAddress.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = BreakpointResolverAddress.cpp; path = source/Breakpoint/BreakpointResolverAddress.cpp; sourceTree = "<group>"; };
     26D0DD5410FE555900271C65 /* BreakpointResolverFileLine.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = BreakpointResolverFileLine.cpp; path = source/Breakpoint/BreakpointResolverFileLine.cpp; sourceTree = "<group>"; };
     26D0DD5510FE555900271C65 /* BreakpointResolverName.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = BreakpointResolverName.cpp; path = source/Breakpoint/BreakpointResolverName.cpp; sourceTree = "<group>"; };
-    26D1803C16CEBFD300EDFB5B /* KQueue.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = KQueue.cpp; path = source/Utility/KQueue.cpp; sourceTree = "<group>"; };
     26D1804016CEDF0700EDFB5B /* TimeSpecTimeout.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = TimeSpecTimeout.cpp; path = source/Utility/TimeSpecTimeout.cpp; sourceTree = "<group>"; };
-    26D1804416CEE12500EDFB5B /* KQueue.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = KQueue.h; path = source/Utility/KQueue.h; sourceTree = "<group>"; };
     26D1804616CEE12C00EDFB5B /* TimeSpecTimeout.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = TimeSpecTimeout.h; path = source/Utility/TimeSpecTimeout.h; sourceTree = "<group>"; };
     26D27C9D11ED3A4E0024D721 /* ELFHeader.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ELFHeader.cpp; sourceTree = "<group>"; };
     26D27C9E11ED3A4E0024D721 /* ELFHeader.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ELFHeader.h; sourceTree = "<group>"; };
     26D52C1D1A980FE300E5D2FB /* MICmdCmdSymbol.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = MICmdCmdSymbol.cpp; path = "tools/lldb-mi/MICmdCmdSymbol.cpp"; sourceTree = SOURCE_ROOT; };
     26D52C1E1A980FE300E5D2FB /* MICmdCmdSymbol.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MICmdCmdSymbol.h; path = "tools/lldb-mi/MICmdCmdSymbol.h"; sourceTree = SOURCE_ROOT; };
     26D55234159A7DB100708D8D /* libxml2.dylib */ = {isa = PBXFileReference; lastKnownFileType = "compiled.mach-o.dylib"; name = libxml2.dylib; path = /usr/lib/libxml2.dylib; sourceTree = "<absolute>"; };
     26D5E15E135BAEA2006EA0A7 /* OptionGroupArchitecture.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = OptionGroupArchitecture.cpp; path = source/Interpreter/OptionGroupArchitecture.cpp; sourceTree = "<group>"; };
     26D5E160135BAEB0006EA0A7 /* OptionGroupArchitecture.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = OptionGroupArchitecture.h; path = include/lldb/Interpreter/OptionGroupArchitecture.h; sourceTree = "<group>"; };
2682F168115ED9C800CCFF99 /* Utility */ = {
         3F81691B1ABA242B001DA9DF /* ConvertEnum.h */,
         3F8169171ABA2419001DA9DF /* ConvertEnum.cpp */,
         9481FE6B1B5F2D9200DED357 /* Either.h */,
         4C73152119B7D71700F865A4 /* Iterable.h */,
         942829541A89614000521B30 /* JSON.h */,
         942829551A89614C00521B30 /* JSON.cpp */,
         943BDEFC1AA7B2DE00789CE8 /* LLDBAssert.h */,
         943BDEFD1AA7B2F800789CE8 /* LLDBAssert.cpp */,
-        26D1804416CEE12500EDFB5B /* KQueue.h */,
-        26D1803C16CEBFD300EDFB5B /* KQueue.cpp */,
         3F81691C1ABA242B001DA9DF /* NameMatches.h */,
         3F8169181ABA2419001DA9DF /* NameMatches.cpp */,
         94031A9F13CF5B3D00DCFF3C /* PriorityPointerPair.h */,
         94F6C4D119C264C70049D089 /* ProcessStructReader.h */,
         2682F16B115EDA0D00CCFF99 /* PseudoTerminal.h */,
         2682F16A115EDA0D00CCFF99 /* PseudoTerminal.cpp */,
         4CAB257C18EC9DB800BAD33E /* SafeMachO.h */,
         26A375841D59487700D6CBDB /* SelectHelper.h */,
2689FFC613353D7A00698AC0 /* Sources */ = {
         26DB3E161379E7AD0080DC73 /* ABIMacOSX_arm.cpp in Sources */,
         26DB3E191379E7AD0080DC73 /* ABIMacOSX_arm64.cpp in Sources */,
         2374D7531D4BB2FF005C9575 /* GDBRemoteClientBase.cpp in Sources */,
         8C2D6A5E197A250F006989C9 /* MemoryHistoryASan.cpp in Sources */,
         26F006561B4DD86700B872E5 /* DynamicLoaderWindowsDYLD.cpp in Sources */,
         26DB3E1C1379E7AD0080DC73 /* ABIMacOSX_i386.cpp in Sources */,
         26DB3E1F1379E7AD0080DC73 /* ABISysV_x86_64.cpp in Sources */,
         232CB61D191E00CD00EF39FC /* SoftwareBreakpoint.cpp in Sources */,
-        26D1803E16CEBFD300EDFB5B /* KQueue.cpp in Sources */,
         26A69C5F137A17A500262477 /* RegisterValue.cpp in Sources */,
         2690B3711381D5C300ECFBAE /* Memory.cpp in Sources */,
         4C562CC71CC07DF700C52EAC /* PDBASTParser.cpp in Sources */,
         B28058A1139988B0002D96D0 /* InferiorCallPOSIX.cpp in Sources */,
         AF20F76A1AF18F9000751A6E /* ABISysV_arm64.cpp in Sources */,
         26F73062139D8FDB00FD51C7 /* History.cpp in Sources */,
         4CCA644D13B40B82003BDF98 /* ItaniumABILanguageRuntime.cpp in Sources */,
         4CCA645013B40B82003BDF98 /* AppleObjCRuntime.cpp in Sources */,

source/Utility/CMakeLists.txt

 add_lldb_library(lldbUtility
   ARM_DWARF_Registers.cpp
   ARM64_DWARF_Registers.cpp
   ConvertEnum.cpp
   JSON.cpp
-  KQueue.cpp
   LLDBAssert.cpp
   ModuleCache.cpp
   NameMatches.cpp
   PseudoTerminal.cpp
   Range.cpp
   RegisterNumber.cpp
   SelectHelper.cpp
   SharingPtr.cpp
   StringExtractor.cpp
   StringExtractorGDBRemote.cpp
   StringLexer.cpp
   TaskPool.cpp
   TimeSpecTimeout.cpp
   UriParser.cpp
   )

source/Utility/KQueue.h

-//===--------------------- KQueue.h -----------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#ifndef utility_KQueue_h_
-#define utility_KQueue_h_
-
-#if defined(__APPLE__)
-#define LLDB_USE_KQUEUES
-#endif
-
-#ifdef LLDB_USE_KQUEUES
-
-#include <sys/event.h>
-#include <sys/time.h>
-#include <sys/types.h>
-
-#include "lldb/lldb-defines.h"
-
-namespace lldb_private {
-
-class KQueue {
-public:
-  KQueue() : m_fd(-1) {}
-
-  ~KQueue() { Close(); }
-
-  bool IsValid() const { return m_fd >= 0; }
-
-  int GetFD(bool can_create);
-
-  int Close();
-
-  bool AddFDEvent(int fd, bool read, bool write, bool vnode);
-
-  int WaitForEvents(
-      struct kevent *events, int num_events, Error &error,
-      uint32_t timeout_usec = UINT32_MAX); // UINT32_MAX means infinite timeout
-
-protected:
-  int m_fd; // The kqueue fd
-};
-
-} // namespace lldb_private
-
-#endif // #ifdef LLDB_USE_KQUEUES
-
-#endif // #ifndef utility_KQueue_h_

source/Utility/KQueue.cpp

-//===--------------------- KQueue.cpp ---------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#include "KQueue.h"
-
-#ifdef LLDB_USE_KQUEUES
-
-#include "lldb/Core/Error.h"
-
-#include "Utility/TimeSpecTimeout.h"
-
-using namespace lldb_private;
-
-int KQueue::GetFD(bool can_create) {
-  if (!IsValid() && can_create)
-    m_fd = kqueue();
-  return m_fd;
-}
-
-int KQueue::Close() {
-  const int fd = m_fd;
-  if (fd >= 0) {
-    m_fd = -1;
-    return close(fd);
-  }
-  return 0;
-}
-
-int KQueue::WaitForEvents(struct kevent *events, int num_events, Error &error,
-                          uint32_t timeout_usec) {
-  const int fd_kqueue = GetFD(false);
-  if (fd_kqueue >= 0) {
-    TimeSpecTimeout timeout;
-    const struct timespec *timeout_ptr =
-        timeout.SetRelativeTimeoutMircoSeconds32(timeout_usec);
-    int result = ::kevent(fd_kqueue, NULL, 0, events, num_events, timeout_ptr);
-    if (result == -1)
-      error.SetErrorToErrno();
-    else
-      error.Clear();
-    return result;
-  } else {
-    error.SetErrorString("invalid kqueue fd");
-  }
-  return 0;
-}
-
-bool KQueue::AddFDEvent(int fd, bool read, bool write, bool vnode) {
-  const int fd_kqueue = GetFD(true);
-  if (fd_kqueue >= 0) {
-    struct kevent event;
-    event.ident = fd;
-    event.filter = 0;
-    if (read)
-      event.filter |= EVFILT_READ;
-    if (write)
-      event.filter |= EVFILT_WRITE;
-    if (vnode)
-      event.filter |= EVFILT_VNODE;
-    event.flags = EV_ADD | EV_CLEAR;
-    event.fflags = 0;
-    event.data = 0;
-    event.udata = NULL;
-    int err = ::kevent(fd_kqueue, &event, 1, NULL, 0, NULL);
-    return err == 0;
-  }
-  return false;
-}
-
-#endif