This is an archive of the discontinued LLVM Phabricator instance.

Fix Clang-tidy readability-redundant-string-cstr warnings
ClosedPublic

Authored by malcolm.parsons on Nov 1 2016, 11:03 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

malcolm.parsons retitled this revision from to Fix Clang-tidy readability-redundant-string-cstr warnings.
malcolm.parsons added a subscriber: cfe-commits.
aaron.ballman accepted this revision.Nov 1 2016, 11:57 AM
aaron.ballman edited edge metadata.

Aside from some formatting nits, this LGTM. You should run the diff through clang-format before committing.

lib/CodeGen/CGObjCGNU.cpp
2650 ↗(On Diff #76601)

Formatting.

lib/CodeGen/TargetInfo.cpp
7460 ↗(On Diff #76601)

Formatting (since you're touching it anyway).

lib/Frontend/CompilerInvocation.cpp
1472 ↗(On Diff #76601)

Formatting.

lib/Frontend/Rewrite/RewriteObjC.cpp
5653 ↗(On Diff #76601)

Formatting. Same below.

unittests/AST/ASTImporterTest.cpp
75 ↗(On Diff #76601)

Possibly formatting?

This revision is now accepted and ready to land.Nov 1 2016, 11:57 AM
malcolm.parsons edited edge metadata.

clang-format

This revision was automatically updated to reflect the committed changes.