This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Set default build type correctly
ClosedPublic

Authored by smeenai on Nov 1 2016, 9:53 AM.

Details

Summary

At least with cmake 3.6.1, the default build type setting was having no
effect; the generated CMakeCache.txt still had an empty CMAKE_BUILD_TYPE.
Force the variable to be set to achieve the desired behavior.

Diff Detail

Repository
rL LLVM

Event Timeline

smeenai updated this revision to Diff 76584.Nov 1 2016, 9:53 AM
smeenai retitled this revision from to [CMake] Set default build type correctly.
smeenai updated this object.
smeenai added reviewers: beanz, compnerd, rafael.
smeenai added a subscriber: llvm-commits.
beanz accepted this revision.Nov 1 2016, 4:20 PM
beanz edited edge metadata.

Yep. LGTM.

This revision is now accepted and ready to land.Nov 1 2016, 4:20 PM
This revision was automatically updated to reflect the committed changes.