This is an archive of the discontinued LLVM Phabricator instance.

Bitcode: Simplify BitstreamWriter::EnterBlockInfoBlock() interface.
ClosedPublic

Authored by pcc on Oct 31 2016, 3:00 PM.

Details

Summary

No block info block should need to define local abbreviations, so we can
always use a code width of 2.

Also change all block info block writers to use EnterBlockInfoBlock.

Event Timeline

pcc updated this revision to Diff 76486.Oct 31 2016, 3:00 PM
pcc retitled this revision from to Bitcode: Simplify BitstreamWriter::EnterBlockInfoBlock() interface..
pcc updated this object.
pcc added a reviewer: mehdi_amini.
pcc added a subscriber: llvm-commits.
mehdi_amini edited edge metadata.Oct 31 2016, 6:09 PM

Motivation is just serialization size here, right?

pcc added a comment.Oct 31 2016, 6:18 PM

I am about to make EnterBlockInfoBlock more complicated in order to deal with multiple block info blocks, so I need all block info block writers to go through this function. The code width thing is just something I noticed in passing.

mehdi_amini accepted this revision.Oct 31 2016, 6:19 PM
mehdi_amini edited edge metadata.

OK, so no particular motivation other than cleanup IIUC.

LGTM, thks.

This revision is now accepted and ready to land.Oct 31 2016, 6:19 PM
This revision was automatically updated to reflect the committed changes.