This is an archive of the discontinued LLVM Phabricator instance.

Paths

[tsan] Enable the tsan/libcxx/ testcase(s) on Darwin
ClosedPublic

Authored by kubamracek on Oct 31 2016, 1:44 PM.

Reviewers

dvyukov

Commits

Summary

Apparently, the std_shared_ptr.cc testcase works fine on Darwin, even without the instrumented libcxx. Let's enable it.

kubamracek retitled this revision from to [tsan] Enable the tsan/libcxx/ testcase(s) on Darwin.

kubamracek updated this object.

kubamracek added a reviewer: dvyukov.

kubamracek set the repository for this revision to rL LLVM.

kubamracek added a project: Restricted Project.

LGTM with a nit

test/tsan/libcxx/lit.local.cfg
8	s/we an/we have an/

This revision is now accepted and ready to land.Oct 31 2016, 1:58 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

test/

tsan/

libcxx/

4 lines

	def getRoot(config):			def getRoot(config):
	if not config.parent:			if not config.parent:
	return config			return config
	return getRoot(config.parent)			return getRoot(config.parent)

	root = getRoot(config)			root = getRoot(config)

	if not root.has_libcxx:			# Only run if we an instrumented libcxx. On Darwin, run always (we have
				dvyukovUnsubmitted Not Done Reply Inline Actions s/we an/we have an/ dvyukov: s/we an/we have an/
				# interceptors to support the system-provided libcxx).
				if not root.has_libcxx and root.host_os != 'Darwin':
	config.unsupported = True			config.unsupported = True