This is an archive of the discontinued LLVM Phabricator instance.

Differential D26162

[tsan] Enable the tsan/libcxx/ testcase(s) on Darwin
ClosedPublic

Authored by kubamracek on Oct 31 2016, 1:44 PM.

Details

Reviewers
dvyukov
Commits
rGbe0f80a28409: [tsan] Enable the tsan/libcxx/ testcase(s) on Darwin
rCRT285634: [tsan] Enable the tsan/libcxx/ testcase(s) on Darwin
rL285634: [tsan] Enable the tsan/libcxx/ testcase(s) on Darwin
Summary

Apparently, the std_shared_ptr.cc testcase works fine on Darwin, even without the instrumented libcxx. Let's enable it.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 76468.Oct 31 2016, 1:44 PM
kubamracek retitled this revision from to [tsan] Enable the tsan/libcxx/ testcase(s) on Darwin.
kubamracek updated this object.
kubamracek added a reviewer: dvyukov.
kubamracek set the repository for this revision to rL LLVM.
kubamracek added a project: Restricted Project.
kubamracek added subscribers: llvm-commits, zaks.anna.
dvyukov accepted this revision.Oct 31 2016, 1:58 PM
dvyukov edited edge metadata.

LGTM with a nit

test/tsan/libcxx/lit.local.cfg
8 ↗(On Diff #76468)

s/we an/we have an/

This revision is now accepted and ready to land.Oct 31 2016, 1:58 PM
Closed by commit rL285634: [tsan] Enable the tsan/libcxx/ testcase(s) on Darwin (authored by kuba.brecka). · Explain WhyOct 31 2016, 1:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
test/
tsan/
libcxx/
4 lines

Diff 76473

compiler-rt/trunk/test/tsan/libcxx/lit.local.cfg

def getRoot(config): def getRoot(config):
if not config.parent: if not config.parent:
return config return config
return getRoot(config.parent) return getRoot(config.parent)
root = getRoot(config) root = getRoot(config)
if not root.has_libcxx: # Only run if we have an instrumented libcxx. On Darwin, run always (we have
# interceptors to support the system-provided libcxx).
if not root.has_libcxx and root.host_os != 'Darwin':
config.unsupported = True config.unsupported = True