In these tests there are some paths that explicitly throw, so use
the TEST_THROW macro that was proposed for this and then skip the tests
that may enter the throwing path.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM after addressing inline comments.
Thanks again!
test/std/experimental/optional/optional.object/optional.object.ctor/copy.pass.cpp | ||
---|---|---|
30 ↗ | (On Diff #76383) | #ifdef TEST_HAS_NO_EXCEPTIONS if (is_going_to_throw) return; #else try #endif |
41 ↗ | (On Diff #76383) | also add `assert(is_going_to_throw);` |
test/std/experimental/optional/optional.object/optional.object.ctor/move.pass.cpp | ||
30 ↗ | (On Diff #76383) | Some comments as above. |