This is an archive of the discontinued LLVM Phabricator instance.

[lsan] Relax check for allocator_end in ProcessGlobalRegionsCallback.
ClosedPublic

Authored by m.ostapenko on Oct 25 2016, 8:45 AM.

Details

Summary

While testing I hit on CHECK_LE(allocator_end, end) randomly from one build to another. Looking to GetAllocatorGlobalRange(&allocator_begin, &allocator_end) just few lines above this check, It appears that allocator_end theoretically may become equal to end (if allocator locates in top addresses of corresponding global section).
Just relax this check to avoid such failure.

Diff Detail

Repository
rL LLVM

Event Timeline

m.ostapenko retitled this revision from to [lsan] Relax check for allocator_end in ProcessGlobalRegionsCallback..
m.ostapenko updated this object.
m.ostapenko added reviewers: kcc, eugenis, aizatsky.
m.ostapenko set the repository for this revision to rL LLVM.
m.ostapenko added a project: Restricted Project.
m.ostapenko added subscribers: llvm-commits, ygribov.
kcc accepted this revision.Oct 25 2016, 9:50 AM
kcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 25 2016, 9:50 AM
This revision was automatically updated to reflect the committed changes.