Fix format string for err_os_log_argument_to_big (currently unused)

[mehdi_amini]

Good catch! How did you find this?
We need a test though.
(I can take over if you want, as I introduced the issue in the first place)

[sammccall]

In D25936#578341, @mehdi_amini wrote:

Good catch! How did you find this?

We've got a library that parses diagnostics that consumes DiagnosticSemaKinds.inc, and it failed to parse this message format.

We need a test though.
(I can take over if you want, as I introduced the issue in the first place)

Thanks! I'm pretty new to llvm and wasn't sure how to test this.
Looks like bkramer came up with one though.

cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

def warn_cfstring_truncated : Warning<
   "belong to the input codeset UTF-8">,
   InGroup<DiagGroup<"CFString-literal">>;
 
 // os_log checking
 // TODO: separate diagnostic for os_trace()
 def err_os_log_format_not_string_constant : Error<
   "os_log() format argument is not a string constant">;
 def err_os_log_argument_too_big : Error<
-  "os_log() argument %d is too big (%d bytes, max %d)">;
+  "os_log() argument %0 is too big (%1 bytes, max %2)">;
 def warn_os_log_format_narg : Error<
  "os_log() '%%n' format specifier is not allowed">, DefaultError;
 
 // Statements.
 def err_continue_not_in_loop : Error<
   "'continue' statement not in loop statement">;
 def err_break_not_in_loop_or_switch : Error<
   "'break' statement not in loop or switch statement">;

cfe/trunk/test/SemaObjC/format-strings-oslog.m

void test_os_log_format(const char *pc, int i, void *p, void *buf) {
 
   // <rdar://problem/24828090>
   wchar_t wc = 'a';
   __builtin_os_log_format(buf, "%C", wc);
   printf("%C", wc);
   wchar_t wcs[] = {'a', 0};
   __builtin_os_log_format(buf, "%S", wcs);
   printf("%S", wcs);
+
+  struct { char data[0x100]; } toobig;
+  __builtin_os_log_format(buf, "%s", toobig); // expected-error {{os_log() argument 2 is too big (256 bytes, max 255)}}
 }
 
 // Test os_log_format primitive with ObjC string literal format argument.
 void test_objc(const char *pc, int i, void *p, void *buf, NSString *nss) {
   __builtin_os_log_format(buf, @"");
   __builtin_os_log_format(buf, @"%d"); // expected-warning {{more '%' conversions than data arguments}}
   __builtin_os_log_format(buf, @"%d", i);
   __builtin_os_log_format(buf, @"%P", p); // expected-warning {{using '%P' format specifier without precision}}