This is an archive of the discontinued LLVM Phabricator instance.

[CodeView] Refactor lots of stuff to use StreamRefs
ClosedPublic

Authored by zturner on Oct 20 2016, 9:23 AM.

Details

Summary

I started down the path of trying to merge the serialization and deserialization for types and symbols. This is difficult as it stands, because all of the "real" PDB code uses StreamInterface stuff to avoid having to copy entire streams, which could be hundreds of MB. But the serialization code all uses ArrayRef for everything. This changes everything to use StreamReader. In the process, I found lots of duplicated code in RecordSerialization.cpp and RecordSerailization.h that was already written in StreamReader.cpp. All of that has been removed since everything is now using StreamReader.

Diff Detail

Event Timeline

zturner updated this revision to Diff 75312.Oct 20 2016, 9:23 AM
zturner retitled this revision from to [CodeView] Refactor lots of stuff to use StreamRefs.
zturner updated this object.
zturner added reviewers: rnk, inglorion.
zturner added a subscriber: llvm-commits.
rnk accepted this revision.Oct 20 2016, 11:11 AM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Oct 20 2016, 11:11 AM
This revision was automatically updated to reflect the committed changes.