This is an archive of the discontinued LLVM Phabricator instance.

[Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC)
ClosedPublic

Authored by vsk on Oct 17 2016, 5:16 PM.

Diff Detail

Event Timeline

vsk updated this revision to Diff 74935.Oct 17 2016, 5:16 PM
vsk retitled this revision from to [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC).
vsk updated this object.
vsk added a reviewer: jlebar.
vsk added a subscriber: cfe-commits.
jlebar accepted this revision.Oct 17 2016, 5:18 PM
jlebar edited edge metadata.

The great thing about unique_ptr is, if it compiles, we're probably good. :)

This revision is now accepted and ready to land.Oct 17 2016, 5:18 PM
This revision was automatically updated to reflect the committed changes.
malcolm.parsons added inline comments.
cfe/trunk/lib/Basic/SourceManager.cpp
1941 ↗(On Diff #74937)

Redundant .get()