This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Use stem rather than filename for executable name
ClosedPublic

Authored by phosek on Oct 17 2016, 2:29 PM.

Details

Summary

When comparing the linker name in Fuchsia driver, use stem rather than filename to get the name of the linker becase on Windows, the filename will have an extension.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek updated this revision to Diff 74905.Oct 17 2016, 2:29 PM
phosek retitled this revision from to [Driver] Use stem rather than filename for executable name.
phosek updated this object.
phosek added a reviewer: davide.
phosek set the repository for this revision to rL LLVM.
phosek added a subscriber: cfe-commits.
bruno added a reviewer: bruno.Oct 17 2016, 2:38 PM
bruno added a subscriber: bruno.

Can you add a testcase for that?

davide accepted this revision.Oct 17 2016, 2:38 PM
davide edited edge metadata.

Was going to commit the same. Thanks. LGTM.

This revision is now accepted and ready to land.Oct 17 2016, 2:38 PM

And yes, if you can add a test case that will be great (there's no bot that caught this upstream) but one of our internal bots did.

Can you add a testcase for that?

This is already covered by an existing testcase which was failing on Windows (davide pointed that out to me).

bruno accepted this revision.Oct 17 2016, 3:07 PM
bruno edited edge metadata.

Ok, thanks! LGTM

This revision was automatically updated to reflect the committed changes.