[Coverage] Support loading multiple files into a CoverageMapping
ClosedPublic
Actions

Authored by vsk on Oct 12 2016, 3:41 PM.

Details

Reviewers

MaggieYi
arphaman
ikudrin

Commits

rG743574b8e3f2: [Coverage] Support loading multiple binaries into a CoverageMapping
rL284251: [Coverage] Support loading multiple binaries into a CoverageMapping

Summary

Add support for loading multiple coverage readers into a CoverageMapping
instance. This should make it easier to prepare coverage reports for
multiple binaries.

This should make it possible to substantially simplify D25086.

Diff Detail

Repository: rL LLVM

Event Timeline

vsk updated this revision to Diff 74451.Oct 12 2016, 3:41 PM

vsk retitled this revision from to [Coverage] Support loading multiple files into a CoverageMapping.

vsk updated this object.

vsk added reviewers: MaggieYi, arphaman, ikudrin.

vsk added a subscriber: llvm-commits.

Thanks for working on this!

unittests/ProfileData/CoverageMappingTest.cpp
285 ↗	(On Diff #74451)	I noticed that you have a bunch `CoverageMappingTest` renaming changes in this patch. Do you think it would be better to do the rename in a separate commit before this patch? So get rid of `MaybeSparseCoverageMappingTest` and make `CoverageMappingTest` a `bool` parameter test, and then in the second commit make `CoverageMappingTest` a `std::pair<bool, bool>` test? You don't have to split this patch, just the commits.