This is an archive of the discontinued LLVM Phabricator instance.

Differential D25372

[Polly] Define PATH_MAX on windows
ClosedPublic

Authored by etherzhhb on Oct 7 2016, 10:49 AM.

Details

Reviewers
Meinersbur
grosser
jdoerfert
Commits
rG5860aef6759f: Define PATH_MAX on windows
rPLO283600: Define PATH_MAX on windows
rL283600: Define PATH_MAX on windows
Summary

Define PATH_MAX on windows such that we can compile Polly on windows with MSVC!

Diff Detail

Repository
rL LLVM

Event Timeline

etherzhhb updated this revision to Diff 73954.Oct 7 2016, 10:49 AM
etherzhhb retitled this revision from to [Polly] Define PATH_MAX on windows.
etherzhhb updated this object.
etherzhhb added reviewers: grosser, jdoerfert, Meinersbur.
etherzhhb set the repository for this revision to rL LLVM.
etherzhhb added a project: Restricted Project.
etherzhhb added a subscriber: Restricted Project.
Herald added subscribers: mgorny, beanz. · View Herald TranscriptOct 7 2016, 10:49 AM
Meinersbur accepted this revision.Oct 7 2016, 12:27 PM
Meinersbur edited edge metadata.

I'd personally prefer target_compile_definitions, but this works as well.

This revision is now accepted and ready to land.Oct 7 2016, 12:27 PM
etherzhhb updated this revision to Diff 73971.Oct 7 2016, 12:33 PM
etherzhhb edited edge metadata.

Do you mean something like this?

Meinersbur added a comment.Oct 7 2016, 12:37 PM

Yes, exactly. It the macro to where it is needed. Thanks.

Closed by commit rL283600: Define PATH_MAX on windows (authored by ether). · Explain WhyOct 7 2016, 2:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
polly/
trunk/
lib/
External/
6 lines

Diff 73986

polly/trunk/lib/External/CMakeLists.txt

Show First 20 Lines • Show All 333 Lines • ▼ Show 20 Linesif (MSVC)
target_compile_options(PollyISL PRIVATE ${DISABLE_WARNING_FLAGS}) target_compile_options(PollyISL PRIVATE ${DISABLE_WARNING_FLAGS})
target_compile_options(polly-isl-test PRIVATE ${DISABLE_WARNING_FLAGS}) target_compile_options(polly-isl-test PRIVATE ${DISABLE_WARNING_FLAGS})
target_compile_options(PollyPPCG PRIVATE ${DISABLE_WARNING_FLAGS}) target_compile_options(PollyPPCG PRIVATE ${DISABLE_WARNING_FLAGS})
else () else ()
set_target_properties(PollyISL polly-isl-test PollyPPCG PROPERTIES set_target_properties(PollyISL polly-isl-test PollyPPCG PROPERTIES
COMPILE_FLAGS "-w" COMPILE_FLAGS "-w"
) )
endif () endif ()
if(MSVC)
# In the Windows API (with some exceptions), the maximum length for a path is
# MAX_PATH, which is defined as 260 characters.
target_compile_definitions(PollyPPCG PUBLIC "-DPATH_MAX=260")
endif ()