This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Install 'clang-cpp' symlink
ClosedPublic

Authored by mgorny on Oct 2 2016, 12:07 AM.

Details

Summary

Install the 'clang-cpp' symlink used to spawn the preprocessor. The code handling this suffix is already included in Driver. FreeBSD is already creating such a symlink in ports, and a similar one was requested by Gentoo/FreeBSD team. The goal is to handle software that takes a C preprocessor via a variable but does not handle passing options correctly (i.e. 'clang -E' does not work).

Bug: https://bugs.gentoo.org/478810

Diff Detail

Event Timeline

mgorny updated this revision to Diff 73214.Oct 2 2016, 12:07 AM
mgorny retitled this revision from to [cmake] Install 'clang-cpp' symlink.
mgorny updated this object.
mgorny added reviewers: beanz, doug.gregor.
mgorny added a subscriber: cfe-commits.
joerg accepted this revision.Oct 2 2016, 10:50 AM
joerg added a reviewer: joerg.
joerg added a subscriber: joerg.

LGTM, have been doing that in NetBSD for ages as well.

Side note, someone from Apple please make sure that xcode gets a similar link.

This revision is now accepted and ready to land.Oct 2 2016, 10:50 AM

Thanks for the review. Proceeding with the commit now.

mgorny closed this revision.Oct 3 2016, 1:11 AM

I'm going to close this manually since it seems that Phabricator commit processing is stuck somehow.