[lldbmi] Fix prompt which can get inserted in the middle of lldb-mi output

[dawn]

Summary

The code added in svn trunk 264332 causes "(lldb)" to be printed in the middle of program console output. This fix restores the behavior for non-Windows platforms to before the patch.

For a C++ program with the following source:

...
printf("\n#Break: Function parameters - arrays");
printf("\n#Evaluate:A[0]-C[0] + (A[1]-C[1])*1000 #ExpectedEval:%d", 1001);
printf("\n#Evaluate:FuncArr(C,B) #ExpectedEval:%d", RES);
printf("\n#Evaluate:A[0]-C[0] + (A[1]-C[1])*1000 + 0 #ExpectedEval:%d", 0);
printf("\n#Evaluate:ref[0] + ref[1]*10 #ExpectedEval:%d", 65);
printf("\n#Evaluate:FuncArrRet(7,8) #ExpectedLike:deferred");
...

the following output is produced when running the program in lldb-mi:

#Break: Function parameters - arrays
#Evaluate:A[0]-C[0] + (A[1]-C[1])*1000 #ExpectedEval:1001
#Evaluate:FuncArr(C,B) #ExpectedEval:4321
#Evaluate:A[0]-C[0] + (A[1]-C[1])*1000 + 0 #ExpectedEval:0
#Evaluate:ref[0] + ref[1]*10 #ExpectedEval:65
#Evalua(lldb) te:FuncArrRet(7,8) #ExpectedLike:deferred
...

Note the "(lldb) " inserted into the program output of the 6th print statement. This is a problem for debuggers which want to display the program output to the user (or in this case, for a test harness which reads the program output and uses it to interactively test lldb-mi).

[ted]

The problem this scenario has is asynchronous output from 2 different sources. The original fix made Windows (or any lldb without libedit) much better, but I think most non-Windows builds will use libedit, because it's extremely useful. lldb-mi has a different set of constraints; the position of the prompt isn't as important, since users won't use it as a cue to tell when the debugger can accept more input.

Since this improves lldb-mi, and only hurts a use case I think is not very prevalent (LLDB_DISABLE_LIBEDIT on a non-Windows platform), I think it's OK. LGTM.

lldb/trunk/source/Core/IOHandler.cpp

 
 void IOHandlerEditline::PrintAsync(Stream *stream, const char *s, size_t len) {
 #ifndef LLDB_DISABLE_LIBEDIT
   if (m_editline_ap)
     m_editline_ap->PrintAsync(stream, s, len);
   else
 #endif
   {
-    const char *prompt = GetPrompt();
 #ifdef _MSC_VER
+    const char *prompt = GetPrompt();
     if (prompt) {
       // Back up over previous prompt using Windows API
       CONSOLE_SCREEN_BUFFER_INFO screen_buffer_info;
       HANDLE console_handle = GetStdHandle(STD_OUTPUT_HANDLE);
       GetConsoleScreenBufferInfo(console_handle, &screen_buffer_info);
       COORD coord = screen_buffer_info.dwCursorPosition;
       coord.X -= strlen(prompt);
       if (coord.X < 0)
         coord.X = 0;
       SetConsoleCursorPosition(console_handle, coord);
     }
 #endif
     IOHandler::PrintAsync(stream, s, len);
+#ifdef _MSC_VER
     if (prompt)
       IOHandler::PrintAsync(GetOutputStreamFile().get(), prompt,
                             strlen(prompt));
+#endif
   }
 }
 
 // we may want curses to be disabled for some builds
 // for instance, windows
 #ifndef LLDB_DISABLE_CURSES
 
 #define KEY_RETURN 10