Page MenuHomePhabricator

dawn (Dawn Perchik)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2015, 12:19 PM (245 w, 2 d)

Recent Activity

Nov 2 2016

dawn retitled D26260: Fix typo which broke debugging on older OSX systems after r285172. from to Fix typo which broke debugging on older OSX systems after r285172..
Nov 2 2016, 2:02 PM

Sep 30 2016

dawn updated D25137: [lldbmi] Fix prompt which can get inserted in the middle of lldb-mi output.
Sep 30 2016, 3:27 PM
dawn retitled D25137: [lldbmi] Fix prompt which can get inserted in the middle of lldb-mi output from to [lldbmi] Fix prompt which can get inserted in the middle of lldb-mi output.
Sep 30 2016, 3:16 PM

Feb 24 2016

dawn accepted D17274: improve readability and performance of ClangExpressionParser::FindFunctionInModule.

lgtm other than nitpick on formatting. And sorry for delayed review - been sick.

Feb 24 2016, 1:53 PM

Jan 6 2016

dawn added a reviewer for D12809: Better scheme to lookup alternate mangled name when looking up function address.: clayborg.

Adding Greg - he is an excellent reviewer and quite responsive (poor guy - ends up with way more than his fair share of reviews as a result :( ).

Jan 6 2016, 12:45 PM
dawn added a comment to D12809: Better scheme to lookup alternate mangled name when looking up function address..

@spyffe I think this review is waiting on you since you had previously rejected it. Can you please have a look? It continues to show up on my "Blocking Others" list and there's nothing more I can do on my side. Please review or resign out of curtesy to sivachandra??? Thanks in advance.

Jan 6 2016, 12:39 PM

Jan 5 2016

dawn added a comment to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

Amended patch was committed in svn r256877 (svn at lldb.org is back up now)

Jan 5 2016, 4:12 PM
dawn added a comment to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

Amended patch was posted to http://reviews.llvm.org/D15904 - hopefully someone who can get to llvm.org will commit.

Jan 5 2016, 2:28 PM
dawn retitled D15904: Fix tests after svn r256863 - can someone please commit? from to Fix tests after svn r256863 - can someone please commit?.
Jan 5 2016, 2:25 PM
dawn added a comment to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

I forgot to commit updated changes to the tests:

MiSymbolTestCase.test_lldbmi_symbol_list_lines_file
HelpCommandTestCase.test_help_image_du_line_should_work

so they are failing now, but svn at llvm.org appears to be down at the moment.
I'll commit those changes as soon as svn is back up...

Jan 5 2016, 1:06 PM
dawn added a comment to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

... in the future when adding things for MI, please add an API in the lldb::SB layer to do what you need.

Jan 5 2016, 10:47 AM

Jan 4 2016

dawn added a comment to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

Hopefully folks are back from the holidays by now - can someone give this a look? Thanks in advance...

Jan 4 2016, 7:53 PM

Dec 21 2015

dawn updated the diff for D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..
Dec 21 2015, 8:10 PM
dawn added a comment to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

Replies to Ilia's comments...

Dec 21 2015, 8:03 PM
dawn added a comment to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

Dawn, if you don't understand what I asked you to do,

Dec 21 2015, 7:07 PM

Dec 17 2015

dawn updated the diff for D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

Updated patch with suggestions from Ilia's review (thanks Ilia!).

Dec 17 2015, 10:27 AM
dawn added a comment to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

clang-format your changes please (there are many deviations from the coding style)

Dec 17 2015, 10:25 AM

Dec 16 2015

dawn updated the diff for D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..
Dec 16 2015, 11:23 PM
dawn added a comment to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

I'm only going to support the combinations:

--compile-unit-only true --only-explicit-matches false --show-raw true
--compile-unit-only false --only-explicit-matches true --show-raw false

OK?

Dec 16 2015, 6:18 PM
dawn added a comment to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

So it seems like your change is adding three flags

--compile-unit-only --only-explicit-matches --show-raw

or something. The current behavior is:

--compile-unit-only true --only-explicit-matches false --show-raw true

and your command does:

--compile-unit-only false --only-explicit-matches true --show-raw false

Does that seem right.

Dec 16 2015, 6:02 PM
dawn added a comment to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

I don't think this is sufficiently different from "target modules dump line-tables" to warrant a separate command. This seems more like a candidate for a flag to "target modules dump line-tables" like --search-for-inlines or something. That would keep the command surface more manageable and also make the option more discoverable, since you can get both variants in one place.

I first thought about adding it as an option to the line-table but decided against it because the information provided by each are just too different.

Dec 16 2015, 4:36 PM
dawn updated the diff for D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

Updated patch to include changes to TestHelp.py.

Dec 16 2015, 3:42 PM
dawn retitled D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines. from to Add "target modules dump line-entries <file>" command and use it to fix MI's -symbol-list-lines..
Dec 16 2015, 3:09 PM
dawn added a comment to D12809: Better scheme to lookup alternate mangled name when looking up function address..

Can a "code owner" please review this patch? Thanks, -Dawn

Dec 16 2015, 11:45 AM

Dec 15 2015

dawn updated the diff for D15326: Rework breakpoint language filtering to use the symbol context's language..

Updated patch which changes Mangled::GuessLanguage to use the same algorithm for detecting the language from the mangled name as was added to LanguageRuntime::GuessLanguageForSymbolByName.

Dec 15 2015, 2:28 PM

Dec 10 2015

dawn added a comment to D15326: Rework breakpoint language filtering to use the symbol context's language..

ping?

Dec 10 2015, 4:14 PM
dawn updated the diff for D15312: Fix scope-based lookup when more than one function is found..

Updated Clang-specific version of patch.

Dec 10 2015, 4:14 PM

Dec 9 2015

dawn updated the diff for D15312: Fix scope-based lookup when more than one function is found..

This version of the patch is the API "generic" version of the patch. Please choose to review which ever is preferred, and I will submit another patch based on that version if needed.

Dec 9 2015, 10:03 PM
dawn updated the diff for D15312: Fix scope-based lookup when more than one function is found..

This version of the patch makes the API specific to clang.

Dec 9 2015, 9:19 PM
dawn added a comment to D15312: Fix scope-based lookup when more than one function is found..

It seems like you combined "find this decl instance within a decl context" with "find a decl by name in the CompilerDeclContext and optionally get the type".

Dec 9 2015, 8:29 PM
dawn added a comment to D15312: Fix scope-based lookup when more than one function is found..

Hi Greg, I'm working on a new revision to change the patch as you suggest (thanks for your review - you had some great suggestions!).

Dec 9 2015, 11:36 AM

Dec 8 2015

dawn added a comment to D15326: Rework breakpoint language filtering to use the symbol context's language..

Thanks Greg. Will fix comment in commit.

Dec 8 2015, 5:25 PM
dawn requested review of D15326: Rework breakpoint language filtering to use the symbol context's language..

Please reconsider. Thanks.

Dec 8 2015, 3:39 PM
dawn added a reviewer for D15326: Rework breakpoint language filtering to use the symbol context's language.: clayborg.

(Added Greg - he wrote Mangled::GetLanguage - now GuessLanguage).

Dec 8 2015, 3:38 PM
dawn added a comment to D15326: Rework breakpoint language filtering to use the symbol context's language..

The part of this fix which is using info in the SymbolContext to make the language detection more accurate is fine.

We have to do something better about how we detect the language from a mangled name. The target knows some that it should be able to contribute, but there's no clear way to do that now. But you aren't making that any worse (except the one inline comment about cstring_is_mangled above, which will need to get fixed) so I don't think you are obligated to solve that problem now.

Dec 8 2015, 3:28 PM
dawn added a comment to D15312: Fix scope-based lookup when more than one function is found..

Greg: But going forward I would like to see more of "find a struct named 'X'

in CompilerDeclContext 'Y'" queries, instead of ...

Dec 8 2015, 3:12 PM
dawn added a comment to D15312: Fix scope-based lookup when more than one function is found..

Thanks Greg! To address your main point:

So either make it generic, or clang specific.

Dec 8 2015, 2:02 AM

Dec 7 2015

dawn retitled D15326: Rework breakpoint language filtering to use the symbol context's language. from to Rework breakpoint language filtering to use the symbol context's language..
Dec 7 2015, 11:46 PM
dawn updated the diff for D15312: Fix scope-based lookup when more than one function is found..

Updated patch to removed change related to Pascal language - it should be part of a separate patch.

Dec 7 2015, 3:12 PM
dawn retitled D15312: Fix scope-based lookup when more than one function is found. from to Fix scope-based lookup when more than one function is found..
Dec 7 2015, 2:57 PM

Dec 4 2015

dawn retitled D15254: Fix crash when dumping NamedDecl with NULL getQualifier(). from to Fix crash when dumping NamedDecl with NULL getQualifier()..
Dec 4 2015, 6:48 PM
dawn added a comment to D12809: Better scheme to lookup alternate mangled name when looking up function address..

@dawn: Thanks for accepting the patch. I guess I still need to wait for sign-off/comments from a CODE_OWNER.

Dec 4 2015, 11:45 AM

Dec 3 2015

dawn added a comment to D15175: Fix breakpoint language filtering for other C variants (like C99) and Pascal..

Jim, this patch doesn't attempt to fix the issue I raised in my comment - it just fixes the oversight of other C variants (clang picks C99 for example) and renames your function to a more meaningful name (and matches Mangled::GuessLanguage which is also uses the name to guess the language). I see no reason why to reject it.

Dec 3 2015, 9:16 PM
dawn accepted D12809: Better scheme to lookup alternate mangled name when looking up function address..

lgtm. Patch was applied locally and tested with no regressions. Thanks for fixing the patch.

Dec 3 2015, 12:39 AM

Dec 2 2015

dawn retitled D15175: Fix breakpoint language filtering for other C variants (like C99) and Pascal. from to Fix breakpoint language filtering for other C variants (like C99) and Pascal..
Dec 2 2015, 9:41 PM

Nov 24 2015

dawn accepted rL248048: Added support for resolving symbolic links to FileSpec..

Not really an acceptance, but the test that started failing as a result of this commit (LaunchInTerminalTestCase.test_launch_in_terminal) has been XFAILed o OSX in svn.252699 thanks to Todd Fiala. None the less, it would be a good idea to investigate why this commit caused the test to start failing.

Nov 24 2015, 11:21 PM

Nov 16 2015

dawn added a comment to D14631: [dwarf] Handle DWARF forms for address other than DW_FORM_GNU_addr_index and DW_FORM_addr..

How you end up in calling DWARFFormValue::Address() with a value what have a form type other then DW_FORM_addr and DW_FORM_GNU_addr_index? What is the attribute tag and the form type used? Can you post a call stack for the case when you hit this issue?

Nov 16 2015, 11:25 AM

Nov 13 2015

dawn abandoned D14631: [dwarf] Handle DWARF forms for address other than DW_FORM_GNU_addr_index and DW_FORM_addr..

If you have a compiler that is actually emitting addresses incorrectly using DW_FORM_data* when the values are not offsets, the compiler should be fixed.

Nov 13 2015, 12:53 PM

Nov 12 2015

dawn retitled D14631: [dwarf] Handle DWARF forms for address other than DW_FORM_GNU_addr_index and DW_FORM_addr. from to [dwarf] Handle DWARF forms for address other than DW_FORM_GNU_addr_index and DW_FORM_addr..
Nov 12 2015, 6:20 PM
dawn added a comment to D14542: [lldb] Fix name lookup in ClangASTContext.

See inline comment.

Nov 12 2015, 1:49 PM

Nov 11 2015

dawn added a comment to D14522: Support: Recognize Borland DWARF extensions..

Seems OK - if there's any reference documentation you can point to for these attributes please include a reference in the code and/or the commit message.

Nov 11 2015, 10:29 AM
dawn added a comment to D14522: Support: Recognize Borland DWARF extensions..

ping? Please accept - patches to lldb are waiting on this. Thanks.

Nov 11 2015, 9:55 AM
dawn accepted D14542: [lldb] Fix name lookup in ClangASTContext.

Patch is correct - without it we loop through the same decl context again. I've tested it locally - there are no new regressions.

Nov 11 2015, 9:51 AM

Nov 9 2015

dawn updated the diff for D14522: Support: Recognize Borland DWARF extensions..
Nov 9 2015, 8:06 PM
dawn added a reviewer for D14522: Support: Recognize Borland DWARF extensions.: majnemer.
Nov 9 2015, 8:00 PM
dawn retitled D14522: Support: Recognize Borland DWARF extensions. from to Support: Recognize Borland DWARF extensions..
Nov 9 2015, 4:46 PM
dawn requested changes to D12809: Better scheme to lookup alternate mangled name when looking up function address..
  1. Please rebase again - this patch no longer applies cleanly, and fails to build after fixing merge conflicts.
  2. Please add tests.
Nov 9 2015, 1:52 PM
dawn added a reviewer for D12809: Better scheme to lookup alternate mangled name when looking up function address.: evgeny777.

Eugene has been doing some work in this area - perhaps he can accept this patch for you.

Nov 9 2015, 1:29 PM
dawn closed D13073: Add an expression parser for Go.

This was committed in svn r251820.

Nov 9 2015, 1:19 PM

Nov 4 2015

dawn added a comment to D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used..

Could you please take a look at these issues?

TestMiSymbol started to fail on Linux with gcc-4.9:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/6387

Nov 4 2015, 5:15 PM

Oct 23 2015

dawn retitled D14036: [debugserver] Fix OSX build for older XCode versions after r251091. from to [debugserver] Fix OSX build for older XCode versions after r251091..
Oct 23 2015, 6:10 PM

Oct 22 2015

dawn accepted rL250335: Fix codesign command with cmake..

Breakage with older cmake versions fixed in svn r251073.

Oct 22 2015, 3:53 PM
dawn added a comment to rL250335: Fix codesign command with cmake..

Please review http://reviews.llvm.org/D13995 for a proposed fix.

Oct 22 2015, 2:26 PM
dawn retitled D13995: [cmake] Fix cmake build on OSX after r250335 for older versions of cmake from to [cmake] Fix cmake build on OSX after r250335 for older versions of cmake.
Oct 22 2015, 2:25 PM
dawn added a comment to rL250335: Fix codesign command with cmake..

One resolution would be to check for the cmake version and conditionally enable the new code, but that's beyond my capabilities - anyone know how? If not, can we please revert this commit?

Oct 22 2015, 2:25 AM

Oct 21 2015

dawn raised a concern with rL250335: Fix codesign command with cmake..

First, sorry for my delay in reviewing your patch, but I've been on vacation and now am at the C++ ANSI meeting in Kona for this week. But...

Oct 21 2015, 5:03 PM
dawn updated subscribers of rL250335: Fix codesign command with cmake..
Oct 21 2015, 4:50 PM

Oct 8 2015

dawn accepted rL247773: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo.

This test is no longer failing.

Oct 8 2015, 7:12 PM
dawn accepted rL247968: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo.

The filing test was removed by Greg in r249613.

Oct 8 2015, 7:09 PM
dawn accepted D13552: Fix handling of LLDB_VERS_GENERATED_FILE..

Works great! Please commit. (Sorry for delay - I ran into problems with clang crashing on me for unknown reasons - finally got the build working again so I could test).

Oct 8 2015, 5:34 PM
dawn added a comment to D13552: Fix handling of LLDB_VERS_GENERATED_FILE..

Hi Bruce, thanks for this patch! I'll give it a try now...

Oct 8 2015, 11:01 AM
dawn accepted rL249434: Fix Darwin build of lldb-server..

Build fixed in svn r249684.

Oct 8 2015, 6:07 AM
dawn added a comment to D13535: Fix cmake build on OSX after r249434..

FYI - our Jenkins master build just picked up the change and is finally building again - yay!! :)

Oct 8 2015, 6:03 AM
dawn added a comment to D13535: Fix cmake build on OSX after r249434..

I don't know what's broken for you. My build hasn't had any issues on Mac OS X using cmake.

Oct 8 2015, 5:59 AM
dawn added a comment to D13535: Fix cmake build on OSX after r249434..

The way to do this correctly is something like
...

Oct 8 2015, 5:53 AM
dawn added a comment to D13535: Fix cmake build on OSX after r249434..

I went ahead and committed this since the build was completely broken - I'd be happy to apply any suggestions folks make here in subsequent commits.

Oct 8 2015, 5:44 AM
dawn added a reviewer for D13535: Fix cmake build on OSX after r249434.: brucem.
Oct 8 2015, 5:30 AM
dawn added inline comments to D13535: Fix cmake build on OSX after r249434..
Oct 8 2015, 5:22 AM
dawn added inline comments to D13535: Fix cmake build on OSX after r249434..
Oct 8 2015, 5:08 AM

Oct 7 2015

dawn added a comment to rL247773: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo.

What other details are you looking for?

Oct 7 2015, 8:29 PM
dawn added a comment to D13535: Fix cmake build on OSX after r249434..

Can someone accept this patch so I can commit please?

Oct 7 2015, 8:24 PM
dawn added a comment to D13535: Fix cmake build on OSX after r249434..

Works fine on Linux too.

Oct 7 2015, 7:25 PM
dawn added a comment to D13535: Fix cmake build on OSX after r249434..

I can't verify that this works on MacOSX at the moment. Did you verify that this works on other platforms as well?

Oct 7 2015, 5:17 PM
dawn added a comment to rL249434: Fix Darwin build of lldb-server..

See http://reviews.llvm.org/D13535 for a workaround.

Oct 7 2015, 2:47 PM
dawn retitled D13535: Fix cmake build on OSX after r249434. from to Fix cmake build on OSX after r249434..
Oct 7 2015, 2:46 PM
dawn raised a concern with rL249434: Fix Darwin build of lldb-server..

This broke the lldb build on OSX using cmake, when starting from a clean workspace. After this commit, we get:

CMake Error at cmake/modules/AddLLVM.cmake:401 (add_library):
  Cannot find source file:
Oct 7 2015, 2:05 PM
dawn updated subscribers of rL249434: Fix Darwin build of lldb-server..
Oct 7 2015, 2:03 PM

Oct 6 2015

dawn added a comment to rL248048: Added support for resolving symbolic links to FileSpec..

Test TestTerminal.LaunchInTerminalTestCase.test_launch_in_terminal is still failing. Can you please have a look? Thanks.

Oct 6 2015, 5:35 PM
dawn added a comment to rL247709: Make the source-map help grammatical..

This test is still failing. Can you please have a look? Thanks.

Oct 6 2015, 5:34 PM
dawn added a comment to rL247968: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo.

This test is still failing. Can you please have a look? Thanks.

Oct 6 2015, 5:34 PM
dawn added a comment to rL247773: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo.

This test is still failing. Can you please have a look? Thanks.

Oct 6 2015, 5:34 PM

Oct 2 2015

dawn added a comment to D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.

This patch is good to commit now right? It's not marked "accepted" for some reason.

Oct 2 2015, 1:12 PM
dawn added a comment to D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.

You can use clang-format to follow the LLDB coding style, or just do the following:

Oct 2 2015, 1:08 PM
dawn added a comment to D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType..

Can someone please accept and commit this patch so we can use this feature? (After the objections are fixed of course). Thanks.

Oct 2 2015, 1:04 PM

Oct 1 2015

dawn added a comment to D13350: [lldb] Fix evaluation of qualified global variables.

Was this patch run on the entire set of lldb tests? Were there any regressions?

Oct 1 2015, 3:21 PM
dawn added a comment to D13350: [lldb] Fix evaluation of qualified global variables.

This patch fixes bugs:

Oct 1 2015, 3:19 PM

Sep 29 2015

dawn accepted D13267: Decide on the expression language inside UserExpression.

Please apply requested changes, then it's good to commit. Thanks for fixing this!

Sep 29 2015, 8:51 PM
dawn added a comment to rL247836: Add using directives to the clang::DeclContext and fix decls for variables….

Bug https://llvm.org/bugs/show_bug.cgi?id=24995 opened for "regressions" after this commit.

Sep 29 2015, 6:15 PM
dawn accepted rL247746: Search variables based on clang::DeclContext and clang::Decl tree.

Clang (the LLDB compiler) does not ask for the value ScNSpacGl in the global namespace, but just for a value named ScNSpacGl.

Sep 29 2015, 5:44 PM
dawn updated subscribers of rL247836: Add using directives to the clang::DeclContext and fix decls for variables….
Sep 29 2015, 3:53 PM