Add a compiler vendor for Facebook, to enable future vendor-specific
behavior.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
The patch has no tests associated. Also, can you please state what's your long(er) term plan?
As it stands, this is pretty much dead code, unless there's something else coming soon in the pipeline.
The patch implicitly has tests: the unit tests generically walks over the enumeration, so it is covered by existing tests.
This would allow Facebook to play around with changes that they need for local development, which may not necessarily be generic enough or generally correct for merging into the mainline.
I don't think that there is any real maintenance cost associated with adding the additional vendor triple, especially if it doesnt require altering the normal code paths.
Spoke with @davide offline. He's fine with with this, was just curious what the intention here was.
To address @dberlin's comments on the mailing list (I've lost the original mail so I can't reply directly):
So why not keep this patch local as well?
In particular, if this is for local development, keeping this patch local
also helps enforce this since any accidental use of the triple in public
code will break quite obviously.
The intent is to be able to upstream anything generic enough to be generally useful, even where the behavior is vendor-specific.