This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Correct alignment condition
ClosedPublic

Authored by smeenai on Sep 28 2016, 4:09 PM.

Details

Summary

The max alignment is a PE/COFF restriction, not an MSVC-specific
restriction; it also applies to gcc and clang when compiling for
Windows. Change the conditional to _WIN32 to reflect this.

Diff Detail

Event Timeline

smeenai updated this revision to Diff 72923.Sep 28 2016, 4:09 PM
smeenai retitled this revision from to [libc++] Correct alignment condition.
smeenai updated this object.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
EricWF accepted this revision.Sep 28 2016, 6:10 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2016, 6:10 PM
mclow.lists edited edge metadata.Sep 28 2016, 7:02 PM

How is this different from D14259 ??

It's not – I just wasn't aware of the existence of the other one :) That one's been stagnant for a long time though. One of these changes should be abandoned in favor of the other, and I'm fine doing it either way.

@mclow.lists Do you have any preference between this and D14259? I'm fine either way, but I'd want one of them to be committed sooner rather than later.

mclow.lists accepted this revision.Oct 4 2016, 5:09 PM
mclow.lists edited edge metadata.

I will land this, and close the other one, too.

mclow.lists closed this revision.Oct 7 2016, 4:28 PM

Committed as revision 283621