This is an archive of the discontinued LLVM Phabricator instance.

Differential D25045

[Coroutines] Add proper mangling for operator co_await for MicrosoftABI
ClosedPublic

Authored by GorNishanov on Sep 28 2016, 2:25 PM.

Details

Reviewers
rnk
rsmith
Commits
rGe2f51befb821: [Coroutines] Add proper mangling for operator co_await for MicrosoftABI
rC282645: [Coroutines] Add proper mangling for operator co_await for MicrosoftABI
rL282645: [Coroutines] Add proper mangling for operator co_await for MicrosoftABI

Diff Detail

Event Timeline

GorNishanov updated this revision to Diff 72900.Sep 28 2016, 2:25 PM
GorNishanov retitled this revision from to [Coroutines] Add proper mangling for operator co_await for MicrosoftABI.
GorNishanov updated this object.
GorNishanov added reviewers: rsmith, rnk.
GorNishanov added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini. · View Herald TranscriptSep 28 2016, 2:25 PM
rsmith accepted this revision.Sep 28 2016, 3:37 PM
rsmith edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2016, 3:37 PM
Closed by commit rL282645: [Coroutines] Add proper mangling for operator co_await for MicrosoftABI (authored by GorNishanov). · Explain WhySep 28 2016, 3:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
AST/
10 lines
test/
CodeGenCoroutines/
25 lines

Diff 72900

lib/AST/MicrosoftMangle.cpp

Show First 20 Lines • Show All 1,083 Lines • ▼ Show 20 Linesvoid MicrosoftCXXNameMangler::mangleOperatorName(OverloadedOperatorKind OO,
// ?_R3 # RTTI Class Hierarchy Descriptor // ?_R3 # RTTI Class Hierarchy Descriptor
// ?_R4 # RTTI Complete Object Locator // ?_R4 # RTTI Complete Object Locator
// ?_S # local vftable // ?_S # local vftable
// ?_T # local vftable constructor closure // ?_T # local vftable constructor closure
// <operator-name> ::= ?_U # new[] // <operator-name> ::= ?_U # new[]
case OO_Array_New: Out << "?_U"; break; case OO_Array_New: Out << "?_U"; break;
// <operator-name> ::= ?_V # delete[] // <operator-name> ::= ?_V # delete[]
case OO_Array_Delete: Out << "?_V"; break; case OO_Array_Delete: Out << "?_V"; break;
// <operator-name> ::= ?__L # co_await
case OO_Coawait: Out << "?__L"; break;
case OO_Conditional: { case OO_Conditional: {
DiagnosticsEngine &Diags = Context.getDiags(); DiagnosticsEngine &Diags = Context.getDiags();
unsigned DiagID = Diags.getCustomDiagID(DiagnosticsEngine::Error, unsigned DiagID = Diags.getCustomDiagID(DiagnosticsEngine::Error,
"cannot mangle this conditional operator yet"); "cannot mangle this conditional operator yet");
Diags.Report(Loc, DiagID); Diags.Report(Loc, DiagID);
break; break;
} }
case OO_Coawait: {
DiagnosticsEngine &Diags = Context.getDiags();
unsigned DiagID = Diags.getCustomDiagID(DiagnosticsEngine::Error,
"cannot mangle this operator co_await yet");
Diags.Report(Loc, DiagID);
break;
}
case OO_None: case OO_None:
case NUM_OVERLOADED_OPERATORS: case NUM_OVERLOADED_OPERATORS:
llvm_unreachable("Not an overloaded operator"); llvm_unreachable("Not an overloaded operator");
} }
} }
void MicrosoftCXXNameMangler::mangleSourceName(StringRef Name) { void MicrosoftCXXNameMangler::mangleSourceName(StringRef Name) {
// <source name> ::= <identifier> @ // <source name> ::= <identifier> @
▲ Show 20 Lines • Show All 1,926 Lines • Show Last 20 Lines

test/CodeGenCoroutines/microsoft-abi-operator-coawait.cpp

  • This file was added.
// RUN: %clang_cc1 -triple x86_64-pc-windows-msvc18.0.0 -fcoroutines -emit-llvm %s -o - -std=c++14 -disable-llvm-passes | FileCheck %s
struct no_suspend {
bool await_ready() { return true; }
template <typename F> void await_suspend(F) {}
void await_resume() {}
};
struct A {
no_suspend operator co_await() { return {}; }
};
struct B {};
no_suspend operator co_await(B const&) { return {}; }
// CHECK-LABEL: f(
extern "C" void f() {
A a;
B b;
// CHECK: call void @"\01??__LA@@QEAA?AUno_suspend@@XZ"(
a.operator co_await();
// CHECK-NEXT: call i8 @"\01??__L@YA?AUno_suspend@@AEBUB@@@Z"(
operator co_await(b);
}