This is an archive of the discontinued LLVM Phabricator instance.

Warn on empty archive files.
ClosedPublic

Authored by ruiu on Sep 28 2016, 2:00 PM.

Diff Detail

Event Timeline

ruiu updated this revision to Diff 72893.Sep 28 2016, 2:00 PM
ruiu updated this revision to Diff 72894.
ruiu retitled this revision from to Warn on empty archive files..
ruiu updated this object.
ruiu added a reviewer: davide.
ruiu added a subscriber: llvm-commits.
  • Fix the error message.
davide added inline comments.Sep 28 2016, 2:06 PM
ELF/InputFiles.cpp
437–438

This is not entirely correct. In fact, you can use ar with a plugin and it will work just fine. Can you rephrase that in a different way? (e.g. you need to have a version of the archives which can create a bitcode armap?)

ruiu updated this revision to Diff 72897.Sep 28 2016, 2:12 PM
  • Updated the message.

If this gets too spammy for any reason, we can still disable it.

This revision was automatically updated to reflect the committed changes.
grimar added a subscriber: grimar.Sep 29 2016, 1:56 AM

If this gets too spammy for any reason, we can still disable it.

We may not disable, but log() it instead if warning().