This is an archive of the discontinued LLVM Phabricator instance.

Add build script for symbolizer which can be linked into instrumented process.
ClosedPublic

Authored by vitalybuka on Sep 27 2016, 11:41 AM.

Diff Detail

Event Timeline

vitalybuka retitled this revision from to Add build script for symbolizer which can be linked into instrumented process..
vitalybuka updated this object.
vitalybuka added a reviewer: eugenis.
vitalybuka added a subscriber: llvm-commits.
eugenis added inline comments.Sep 27 2016, 12:08 PM
lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
62

this comment does not make sense

69

please remove -w

133

this looks fragile
is it possible to unpack LLVM*.a instead?

138

the build should use sanitizer_symbolizer_hooks.cc in some way

vitalybuka marked 3 inline comments as done.

Comments

vitalybuka updated this revision to Diff 72742.Sep 27 2016, 5:31 PM

fixed test

vitalybuka marked an inline comment as done.Sep 27 2016, 5:42 PM
eugenis added inline comments.Sep 27 2016, 5:54 PM
lib/sanitizer_common/symbolizer/sanitizer_symbolize.cc
21

nullptr

lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
15

Please update the comment.

test/asan/TestCases/Linux/print_memory_profile_test.cc
33

I don't understand the effect of this change.

vitalybuka marked an inline comment as done.

update

vitalybuka marked an inline comment as done.Sep 28 2016, 11:18 AM
eugenis accepted this revision.Sep 28 2016, 11:38 AM
eugenis edited edge metadata.

LGTM

lib/sanitizer_common/symbolizer/sanitizer_symbolize.cc
22

I don't think you need this initializer at all.

This revision is now accepted and ready to land.Sep 28 2016, 11:38 AM
vitalybuka marked an inline comment as done.
vitalybuka edited edge metadata.

initialization

This revision was automatically updated to reflect the committed changes.