Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh | ||
---|---|---|
61 ↗ | (On Diff #72681) | this comment does not make sense |
68 ↗ | (On Diff #72681) | please remove -w |
132 ↗ | (On Diff #72681) | this looks fragile |
137 ↗ | (On Diff #72681) | the build should use sanitizer_symbolizer_hooks.cc in some way |
lib/sanitizer_common/symbolizer/sanitizer_symbolize.cc | ||
---|---|---|
21 ↗ | (On Diff #72743) | nullptr |
lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh | ||
15 ↗ | (On Diff #72743) | Please update the comment. |
test/asan/TestCases/Linux/print_memory_profile_test.cc | ||
33 ↗ | (On Diff #72743) | I don't understand the effect of this change. |
Comment Actions
LGTM
lib/sanitizer_common/symbolizer/sanitizer_symbolize.cc | ||
---|---|---|
21 ↗ | (On Diff #72866) | I don't think you need this initializer at all. |