Page MenuHomePhabricator

[lit] Add instructions to run lit's test suite

Authored by modocache on Sep 27 2016, 8:33 AM.



Diff Detail

Event Timeline

modocache updated this revision to Diff 72658.Sep 27 2016, 8:33 AM
modocache retitled this revision from to [lit] Add instructions to run lit's test suite.
modocache updated this object.
modocache added a reviewer: ddunbar.
modocache updated this revision to Diff 72660.Sep 27 2016, 8:36 AM

Oops, forgot a backslash.

@ddunbar I looked around but couldn't determine whether these tests run as part of LLVM's test suite. Is there anything in place to make sure these don't regress? Or is it up to contributors to ensure they pass?

Also, could you confirm for me that these all currently pass?

ddunbar accepted this revision.Sep 27 2016, 9:22 AM
ddunbar edited edge metadata.

LGTM, thanks!

I believe they do all pass, but they are *not* (IIRC) wired up to run as part of LLVM's tests. We should definitely do that.

One long term project I am interested in is moving lit out into its own project that LLVM just has a process for adopting. That will require some coordination with the community, but should help with lit development.

This revision is now accepted and ready to land.Sep 27 2016, 9:22 AM

@cmatthews may remember, but I think there was a discussion about adding lit's tests to check-llvm in the last year or so. I don't remember why it wasn't done.

At the very least we should wire up a CMake target to run the lit tests.

I think we should just wire it up with all the other tests, from lits perspective it would just be another test suite (like we do with the regular tests and the unit tests).

Since we have CMake wired up to create targets for every sub directory under tests, we should really have a 'check-lit' target too.

Ah, got it... that's a new feature to me, I am so out of the loop. :/