This is an archive of the discontinued LLVM Phabricator instance.

Remove unreachable from apis in posix terminal compat windows and return 0
AbandonedPublic

Authored by carlokok on Sep 27 2016, 5:31 AM.

Details

Reviewers
zturner
Summary

These apis are called by lldb process launching but the unreachable causes them to fail on Windows. However, they don't have to do anything because Windows has implied support for terminals. This reverts the apis to their old behavior before the change to unreachable.

Diff Detail

Repository
rL LLVM

Event Timeline

carlokok updated this revision to Diff 72633.Sep 27 2016, 5:31 AM
carlokok retitled this revision from to Remove unreachable from apis in posix terminal compat windows and return 0.
carlokok updated this object.
carlokok set the repository for this revision to rL LLVM.
carlokok added a project: Restricted Project.
carlokok added a subscriber: Restricted Project.
carlokok added a subscriber: lldb-commits.
carlokok updated this object.Sep 27 2016, 5:37 AM
carlokok abandoned this revision.Jun 14 2018, 4:00 AM

This is from 2016; the code doesn't exist anaymore in this form.

shouldn't these be returning -1 for some of these? Zero usually means no error. You would need to check each unix function and return the right error code for failure.