These apis are called by lldb process launching but the unreachable causes them to fail on Windows. However, they don't have to do anything because Windows has implied support for terminals. This reverts the apis to their old behavior before the change to unreachable.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
shouldn't these be returning -1 for some of these? Zero usually means no error. You would need to check each unix function and return the right error code for failure.