Page MenuHomePhabricator

carlokok (Carlo Kok)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 27 2014, 2:20 PM (268 w, 2 d)

Recent Activity

Jul 4 2019

carlokok added a comment to D64148: [lld][WebAssembly] Fix __start/__stop symbols when combining input segments.

Update: it works if using --no-gc-sections (though obviously that's not a solution)

Jul 4 2019, 1:49 AM · Restricted Project
carlokok added a comment to D64148: [lld][WebAssembly] Fix __start/__stop symbols when combining input segments.

With this patch, the symbols still seem to end up as 0:

Jul 4 2019, 1:47 AM · Restricted Project

Jun 4 2019

carlokok created D62844: lld/macho application_extension support .
Jun 4 2019, 1:08 AM · Restricted Project, lld

Jun 3 2019

carlokok created D62842: tvos_version_min and watchos_version_min flag.
Jun 3 2019, 11:55 PM · Restricted Project, lld

May 28 2019

carlokok updated the diff for D62568: lld/mach-o should set MH_NO_REEXPORTED_DYLIBS if there are no REEXPORT_DYLIB libraries.

Remove unused var

May 28 2019, 10:33 PM · Restricted Project, lld
carlokok created D62568: lld/mach-o should set MH_NO_REEXPORTED_DYLIBS if there are no REEXPORT_DYLIB libraries.
May 28 2019, 10:30 PM · Restricted Project, lld

May 27 2019

carlokok added a comment to D62443: [WebAssembly] Move Emscripten-specific behavior under a --emscripten flag.

I suppose I could; do note they do quite different things:

if (ForceExport || Config->ExportAll)
  return true;
May 27 2019, 6:05 AM · Restricted Project
carlokok added a comment to D62443: [WebAssembly] Move Emscripten-specific behavior under a --emscripten flag.

imo export-dynamic should still work? All it does it export all symbols that are linked in. My compiler uses and depends on that feature (though I can add emscripten as a flag to the linker, I don't think I should).

May 27 2019, 1:06 AM · Restricted Project

Jun 14 2018

carlokok abandoned D24960: Remove unreachable from apis in posix terminal compat windows and return 0.

This is from 2016; the code doesn't exist anaymore in this form.

Jun 14 2018, 4:00 AM · Restricted Project

Sep 27 2016

carlokok updated D24960: Remove unreachable from apis in posix terminal compat windows and return 0.
Sep 27 2016, 5:37 AM · Restricted Project
carlokok updated subscribers of D24960: Remove unreachable from apis in posix terminal compat windows and return 0.
Sep 27 2016, 5:32 AM · Restricted Project
carlokok retitled D24960: Remove unreachable from apis in posix terminal compat windows and return 0 from to Remove unreachable from apis in posix terminal compat windows and return 0.
Sep 27 2016, 5:31 AM · Restricted Project

Jun 6 2016

carlokok committed rL271876: (Minor tweak) Make RegisterContextWindows_x86/x64::GetRegisterInfoAtIndex .
(Minor tweak) Make RegisterContextWindows_x86/x64::GetRegisterInfoAtIndex
Jun 6 2016, 2:47 AM