This is an archive of the discontinued LLVM Phabricator instance.

Differential D24949

[SE] Change CoreTests target name
ClosedPublic

Authored by jhen on Sep 26 2016, 5:34 PM.

Details

Reviewers
jprice
jlebar
Commits
rG7bb01a2dc426: [SE] Change CoreTests target name
rL282491: [SE] Change CoreTests target name
Summary

Call it StreamExecutorCoreTests in order to prevent collision with
targets from other modules.

Diff Detail

Event Timeline

jhen updated this revision to Diff 72590.Sep 26 2016, 5:34 PM
jhen retitled this revision from to [SE] Change CoreTests target name.
jhen updated this object.
jhen added reviewers: jlebar, jprice.
jhen added a subscriber: parallel_libs-commits.
Herald added subscribers: jlebar, mgorny, beanz. · View Herald TranscriptSep 26 2016, 5:34 PM
hfinkel added a subscriber: hfinkel.Sep 26 2016, 5:49 PM

This does seem to fix the problem; thanks!

jlebar edited edge metadata.Sep 26 2016, 8:02 PM

:shrug:, okay!

jlebar accepted this revision.Sep 26 2016, 8:02 PM
jlebar edited edge metadata.
This revision is now accepted and ready to land.Sep 26 2016, 8:02 PM
Closed by commit rL282491: [SE] Change CoreTests target name (authored by jhen). · Explain WhySep 27 2016, 8:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
streamexecutor/
unittests/
CoreTests/
2 lines

Diff 72590

streamexecutor/unittests/CoreTests/CMakeLists.txt

if(STREAM_EXECUTOR_ENABLE_CUDA_PLATFORM) if(STREAM_EXECUTOR_ENABLE_CUDA_PLATFORM)
set(CUDA_TEST_SOURCES cuda/CUDATest.cpp) set(CUDA_TEST_SOURCES cuda/CUDATest.cpp)
endif() endif()
add_se_unittest( add_se_unittest(
CoreTests StreamExecutorCoreTests
DeviceTest.cpp DeviceTest.cpp
KernelSpecTest.cpp KernelSpecTest.cpp
PackedKernelArgumentArrayTest.cpp PackedKernelArgumentArrayTest.cpp
StreamTest.cpp StreamTest.cpp
${CUDA_TEST_SOURCES} ${CUDA_TEST_SOURCES}
) )