This is an archive of the discontinued LLVM Phabricator instance.

[asan] Fix incorrect SEH symbol mangling on win64.
ClosedPublic

Authored by etienneb on Sep 22 2016, 1:03 PM.

Details

Summary

The ASAN unittests are failing (check-asan-dynamic) due to an incorrect symbol name:

LINK : error LNK2001: unresolved external symbol ___asan_seh_interceptor

On win64, the linker is not adding an extra underscore. This was correctly fixed in the same file for other uses.

After that patch, most of the unittests are passing, but some related to SEH needs to be fixed.

Failing Tests (4):
    AddressSanitizer-x86_64-windows-dynamic :: TestCases/Windows/dll_intercept_memchr.cc
    AddressSanitizer-x86_64-windows-dynamic :: TestCases/Windows/dll_intercept_memcpy_indirect.cc
    AddressSanitizer-x86_64-windows-dynamic :: TestCases/Windows/dll_seh.cc
    AddressSanitizer-x86_64-windows-dynamic :: TestCases/Windows/seh.cc

  Expected Passes    : 339
  Passes With Retry  : 3
  Expected Failures  : 16
  Unsupported Tests  : 152
  Unexpected Failures: 4

Diff Detail

Event Timeline

etienneb updated this revision to Diff 72205.Sep 22 2016, 1:03 PM
etienneb retitled this revision from to [asan] Fix incorrect SEH symbol mangling on win64..
etienneb updated this object.
etienneb added reviewers: rnk, kcc.
etienneb added subscribers: cfe-commits, chrisha.
majnemer accepted this revision.Sep 22 2016, 2:15 PM
majnemer added a reviewer: majnemer.
majnemer added a subscriber: majnemer.

LGTM

This revision is now accepted and ready to land.Sep 22 2016, 2:15 PM
etienneb closed this revision.Sep 23 2016, 7:16 AM