Page MenuHomePhabricator

[LLDB] Fix Clang initialization and Clang-tidy modernize-use-nullptr warnings
ClosedPublic

Authored by Eugene.Zelenko on Sep 16 2016, 5:50 PM.

Details

Summary

Looks like RegisterContextNetBSD_x86_64.cpp should use RegisterInfos_x86_64.h as much as possible, but I think will be good idea if platform maintainer will take care about this.

Diff Detail

Repository
rL LLVM

Event Timeline

Eugene.Zelenko retitled this revision from to [LLDB] Fix Clang initialization and Clang-tidy modernize-use-nullptr warnings.
Eugene.Zelenko updated this object.
Eugene.Zelenko added reviewers: labath, zturner.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: lldb-commits.
zturner accepted this revision.Sep 20 2016, 12:52 PM
zturner edited edge metadata.
This revision is now accepted and ready to land.Sep 20 2016, 12:52 PM

There are no debug registers supported right now on NetBSD and I was forced to duplicate the code. It's on TODO and I prefer to streamline the kernel.

labath accepted this revision.Sep 20 2016, 1:27 PM
labath edited edge metadata.
labath added inline comments.
source/Plugins/Process/Utility/RegisterInfos_x86_64.h
12

It's not a "C" include, if it's cstddef now. :) If you could you also move the headers to the end of the include list as well, it would be super great as that is the new style now.

Eugene.Zelenko added inline comments.Sep 20 2016, 1:30 PM
source/Plugins/Process/Utility/RegisterInfos_x86_64.h
12

Will do this in commit. I assume that headers sets comments are obsolete now too. LLVM/Clang doesn't use them.

This revision was automatically updated to reflect the committed changes.