This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Use unsigned compare for eq/ne
ClosedPublic

Authored by arsenm on Sep 16 2016, 5:04 PM.

Details

Summary

For some reason there are both of these available, except
for scalar 64-bit compares which only has u64. I'm not sure
why there are both (I'm guessing it's for the one bit inputs we
don't use), but for consistency always using the
unsigned one.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 71715.Sep 16 2016, 5:04 PM
arsenm retitled this revision from to AMDGPU: Use unsigned compare for eq/ne.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
nhaehnle accepted this revision.Sep 26 2016, 2:44 AM
nhaehnle added a reviewer: nhaehnle.

LGTM

This revision is now accepted and ready to land.Sep 26 2016, 2:44 AM
arsenm closed this revision.Sep 30 2016, 8:01 AM

r282832