This is an archive of the discontinued LLVM Phabricator instance.

Recommit r281457 "Supports adding insertion around non-insertion replacements".
ClosedPublic

Authored by ioeric on Sep 15 2016, 4:58 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

ioeric updated this revision to Diff 71492.Sep 15 2016, 4:58 AM
ioeric retitled this revision from to Recommit r281457 "Supports adding insertion around non-insertion replacements" and fix a bug in getAffectedRanges..
ioeric updated this object.
ioeric updated this object.Sep 15 2016, 5:19 AM
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
ioeric updated this revision to Diff 71495.Sep 15 2016, 5:22 AM
  • Update comment in getAffectedRanges.
ioeric updated this revision to Diff 71777.Sep 19 2016, 1:23 AM
  • Supports adding insertion around non-insertion replacements. Recommit r281457.
  • Also add a test case for calculating ranges for replacements with the same offset.
ioeric retitled this revision from Recommit r281457 "Supports adding insertion around non-insertion replacements" and fix a bug in getAffectedRanges. to Recommit r281457 "Supports adding insertion around non-insertion replacements"..Sep 19 2016, 1:24 AM
ioeric updated this object.

This patch now only recommits D24515 with an additional test case CalculateRangesOfInsertionAroundReplacement.

djasper accepted this revision.Sep 19 2016, 1:32 AM
djasper edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Sep 19 2016, 1:32 AM
This revision was automatically updated to reflect the committed changes.