Page MenuHomePhabricator

[llvm-cov] Add filter and sort table functions to the index page.
AbandonedPublic

Authored by MaggieYi on Sep 14 2016, 2:45 PM.

Details

Reviewers
davidxl
bogner
vsk
Summary

The filter and sort table functions have been added to the index page. The user could user filter input to only show the source files that the users are interested in. The user also could sort the entries of the index table by filename, function coverage, line coverage or region coverage.

Diff Detail

Event Timeline

MaggieYi updated this revision to Diff 71439.Sep 14 2016, 2:45 PM
MaggieYi retitled this revision from to [llvm-cov] Add filter and sort table functions to the index page..
MaggieYi updated this object.
MaggieYi added reviewers: vsk, davidxl, bogner.
MaggieYi added a subscriber: llvm-commits.
vsk edited edge metadata.Sep 19 2016, 2:05 PM

When you mentioned filtering and sorting in D24367 I imagined simple extensions to the -{line,region}-coverage-{lt,gt} options.. I would strongly prefer to not have any javascript in llvm-cov. Apart from not having good tools to test javascript in tree, this opens us up to much more scope creep than I'm comfortable with. E.g, there is already an IE-specific JS hack in this patch.

MaggieYi abandoned this revision.Sep 26 2016, 12:25 AM